From: Andrew Morton <akpm@osdl.org>
To: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: jdike@addtoit.com, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [PATCH 6/9] uml: avoid malloc to sleep in atomic sections
Date: Tue, 17 Jan 2006 16:56:02 -0800 [thread overview]
Message-ID: <20060117165602.3d29f936.akpm@osdl.org> (raw)
In-Reply-To: <20060118001938.14622.47308.stgit@zion.home.lan>
"Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it> wrote:
>
> +int __cant_sleep(void) {
> + return in_atomic() || irqs_disabled() || in_interrupt();
aww, man, this is awful. Code is supposed to know what context it's
running in, not go fishing about in core internals trying to fix up its own
confusion.
> + /* Is in_interrupt() really needed? */
> }
Yes, it is. in_atomic() is a no-op on !PREEMPT and local irq's can be
enabled in soft- or hard- interrupt context, so irqs_disabled() will return
0.
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2006-01-18 0:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060117235659.14622.18544.stgit@zion.home.lan>
2006-01-18 0:19 ` [uml-devel] [PATCH 1/9] uml: avoid sysfs warning on hot-unplug Paolo 'Blaisorblade' Giarrusso
2006-01-18 2:53 ` [uml-devel] " Jeff Dike
2006-01-18 11:11 ` Blaisorblade
2006-01-18 0:19 ` [uml-devel] [PATCH 2/9] uml: make daemon transport behave properly Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:19 ` [uml-devel] [PATCH 3/9] uml: networking - clear transport-specific structure Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:19 ` [uml-devel] [PATCH 4/9] uml: fix spinlock recursion and sleep-inside-spinlock in error path Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:52 ` [uml-devel] " Andrew Morton
2006-01-18 11:44 ` Blaisorblade
2006-01-18 0:19 ` [uml-devel] [PATCH 5/9] uml: sigio code - reduce spinlock hold time Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:19 ` [uml-devel] [PATCH 6/9] uml: avoid malloc to sleep in atomic sections Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:56 ` Andrew Morton [this message]
2006-01-18 11:47 ` [uml-devel] " Blaisorblade
2006-01-18 0:19 ` [uml-devel] [PATCH 7/9] uml: arch Kconfig menu cleanups Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:19 ` [uml-devel] [PATCH 8/9] uml: allow again to move backing file and to override saved location Paolo 'Blaisorblade' Giarrusso
2006-01-18 0:19 ` [uml-devel] [PATCH 9/9] uml ubd code: fix a bit of whitespace Paolo 'Blaisorblade' Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060117165602.3d29f936.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox