linux-um archives
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] Real fix for rejected patch uaccess-warning
Date: Thu, 23 Mar 2006 20:54:29 -0500	[thread overview]
Message-ID: <20060324015429.GB8104@ccure.user-mode-linux.org> (raw)
In-Reply-To: <200603240052.11189.blaisorblade@yahoo.it>

On Fri, Mar 24, 2006 at 12:52:09AM +0100, Blaisorblade wrote:
> We could even do without __private_ptr, and that's surely easier to do. 
> Actually I think that it could be done like for i386:

We can, but I'm looking for a safe patch to quiet the warnings.  I did
strip down __get_user and __put_user with no apparent ill effects, but
I'm not happy sending something like that off to Andrew with 5 minutes
of testing.  I'll put the cleanup patch in my development tree and if
I don't see any problems, then I'll send it off.

> However, I think that get_user doesn't guarantee a "full copy" semantic - 
> include/asm-i386/uaccess.h says it zeroes the dest var on error, so we're 
> safe.

Yeah, I think so.  In which case, these become pretty thin wrappers
around copy_{to,from}_user.

				Jeff


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

      reply	other threads:[~2006-03-24  1:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-07 19:31 [uml-devel] Real fix for rejected patch uaccess-warning Blaisorblade
2006-03-09 16:57 ` Jeff Dike
2006-03-10 15:22   ` Blaisorblade
2006-03-23 20:58     ` Jeff Dike
2006-03-23 23:52       ` Blaisorblade
2006-03-24  1:54         ` Jeff Dike [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060324015429.GB8104@ccure.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=blaisorblade@yahoo.it \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox