From: Jeff Dike <jdike@addtoit.com>
To: tyler@agat.net, user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [PATCH] Task Size Init cleanup
Date: Tue, 23 May 2006 11:37:35 -0400 [thread overview]
Message-ID: <20060523153735.GB4368@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20060522212649.GA4946@portableric>
On Mon, May 22, 2006 at 11:26:49PM +0200, tyler@agat.net wrote:
> I was looking at the code of the UML and more precisely at the functions
> set_task_sizes_tt and set_task_sizes_skas. I noticed that these 2
> functions take a paramater (arg) which is not used : the function is
> always called with the value 0.
You seem not to have tried to compile it, because it doesn't. You missed
the declarations of set_task_sizes_*.
>
> I suppose that this value might change in the future (or even can be
> configured), so I added a constant in mem_user.h file.
This is wrong. set_task_sizes_* use &arg, not arg.
This stuff is fixed, and this patch is in my tree.
Jeff
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2006-05-23 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 21:26 [uml-devel] [PATCH] Task Size Init cleanup user-mode-linux-devel-admin
2006-05-23 15:37 ` Jeff Dike [this message]
2006-06-29 15:35 ` Jeff Dike
2006-06-30 15:31 ` user-mode-linux-devel-bounces
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060523153735.GB4368@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=tyler@agat.net \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox