From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1GXbx9-0004aE-OS for user-mode-linux-devel@lists.sourceforge.net; Wed, 11 Oct 2006 04:08:47 -0700 Received: from web25221.mail.ukl.yahoo.com ([217.146.176.207]) by mail.sourceforge.net with smtp (Exim 4.44) id 1GXbx6-00010d-T9 for user-mode-linux-devel@lists.sourceforge.net; Wed, 11 Oct 2006 04:08:47 -0700 Message-ID: <20061011110828.43576.qmail@web25221.mail.ukl.yahoo.com> Date: Wed, 11 Oct 2006 13:08:27 +0200 (CEST) From: Paolo Giarrusso In-Reply-To: <20061009163208.GA4931@ccure.user-mode-linux.org> MIME-Version: 1.0 Subject: Re: [uml-devel] [PATCH 01/14] uml: fix compilation options for USER_OBJS List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Jeff Dike Cc: Andrew Morton , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Jeff Dike ha scritto: > On Thu, Oct 05, 2006 at 11:38:36PM +0200, Paolo 'Blaisorblade' > Giarrusso wrote: > > Again, move inclusion of arch's Makefile after CFLAGS setting - I > remember > > merging the same patch eons ago in 2.6, so I added a comment. > > > > I discovered this because debug info weren't enabled for > USER_OBJS - they're > > compiled with USER_CFLAGS which is calculated from CFLAGS (the > whole thing is a > > bit of an hack but fixing it is not easy, so we're leaving it > as-is). > > What's the matter with this: > > Index: linux-2.6.18-mm/arch/um/Makefile > =================================================================== > --- linux-2.6.18-mm.orig/arch/um/Makefile 2006-10-03 > 17:44:32.000000000 -0400 > +++ linux-2.6.18-mm/arch/um/Makefile 2006-10-09 > 12:29:32.000000000 -0400 > @@ -64,9 +64,8 @@ CFLAGS += $(CFLAGS-y) -D__arch_um__ -DSU > > AFLAGS += $(ARCH_INCLUDE) > > -USER_CFLAGS := $(patsubst -I%,,$(CFLAGS)) > -USER_CFLAGS := $(patsubst -D__KERNEL__,,$(USER_CFLAGS)) > $(ARCH_INCLUDE) \ > - $(MODE_INCLUDE) -D_FILE_OFFSET_BITS=64 > +USER_CFLAGS = $(patsubst -D__KERNEL__,,$(patsubst -I%,,$(CFLAGS))) > \ > + $(ARCH_INCLUDE) $(MODE_INCLUDE) -D_FILE_OFFSET_BITS=64 > > # -Derrno=kernel_errno - This turns all kernel references to errno > into > # kernel_errno to separate them from the libc errno. This allows > -fno-common > > The real problem is the use of := which assigns USER_CFLAGS from > the > current value of CFLAGS, which is incomplete, as you noted. Ok, at a first glance this alternative solution is ok. Make sure (run gdb on an userspace object file and saying list ) that it works and we'll be ok. > Moving the include around seems slightly bogus, since its precise > location shouldn't matter. > > If we switch to plain =, then it will be lazy-evaluated with the > full > CFLAGS. > > And we should check other uses of := to make sure they don't have > similar problems. Maybe, but I hope not... however if CFLAGS is used elsewhere its occurrences must be looked for and checked. -- Paolo 'Blaisorblade' Giarrusso __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi http://mail.yahoo.it ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel