From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1GecoW-0001ay-P8 for user-mode-linux-devel@lists.sourceforge.net; Mon, 30 Oct 2006 11:28:53 -0800 Received: from [198.99.130.12] (helo=saraswathi.solana.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1GecoV-0001yW-OJ for user-mode-linux-devel@lists.sourceforge.net; Mon, 30 Oct 2006 11:28:52 -0800 Date: Mon, 30 Oct 2006 15:26:57 -0500 From: Jeff Dike Message-ID: <20061030202657.GB6079@ccure.user-mode-linux.org> References: <20061029191723.12292.50164.stgit@americanbeauty.home.lan> <20061029192041.12292.95078.stgit@americanbeauty.home.lan> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20061029192041.12292.95078.stgit@americanbeauty.home.lan> Subject: Re: [uml-devel] [PATCH 07/11] uml ubd driver: reformat ubd_config List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Paolo 'Blaisorblade' Giarrusso Cc: Andrew Morton , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Sun, Oct 29, 2006 at 08:20:41PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso > - return(1); > + ret = 1; > + goto out; > +out: > + return ret; I think the original form should stay, except for the CodingStyle fix. As Al once pointed out, 'goto out; ... out: return' is spelled 'return'. If you have no cleanup to do before returning, you might as well just return. > + if (n == -1) { > + ret = 0; > + goto out; > } > - if(n == -1) return(0); The comment should have noted the bug fix present here. Jeff ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel