From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1H1ZWC-0001lg-GL for user-mode-linux-devel@lists.sourceforge.net; Mon, 01 Jan 2007 18:36:48 -0800 Received: from xenotime.net ([66.160.160.81]) by mail.sourceforge.net with smtp (Exim 4.44) id 1H1ZWC-0001q4-71 for user-mode-linux-devel@lists.sourceforge.net; Mon, 01 Jan 2007 18:36:48 -0800 Received: from midway.site ([71.245.99.70]) by xenotime.net for ; Mon, 1 Jan 2007 18:36:41 -0800 Date: Mon, 1 Jan 2007 18:23:22 -0800 From: Randy Dunlap Message-Id: <20070101182322.b365543a.rdunlap@xenotime.net> In-Reply-To: <4599BAE1.9050804@student.ltu.se> References: <200701011947.l01JlAMo020761@ccure.user-mode-linux.org> <4599BAE1.9050804@student.ltu.se> Mime-Version: 1.0 Subject: Re: [uml-devel] [PATCH 4/8] UML - audio driver formatting List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Richard Knutsson Cc: akpm@osdl.org, Jeff Dike , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Tue, 02 Jan 2007 02:52:33 +0100 Richard Knutsson wrote: > Jeff Dike wrote: > > Whitespace and style fixes. > > > > Signed-off-by: Jeff Dike > > -- > > arch/um/drivers/hostaudio_kern.c | 160 +++++++++++++++++---------------------- > > 1 file changed, 73 insertions(+), 87 deletions(-) > > > > Index: linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c > > =================================================================== > > --- linux-2.6.18-mm.orig/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:41.000000000 -0500 > > +++ linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:42.000000000 -0500 > > @@ -15,11 +15,11 @@ > > #include "os.h" > > > > struct hostaudio_state { > > - int fd; > > + int fd; > > }; > > > > struct hostmixer_state { > > - int fd; > > + int fd; > > }; > > > > #define HOSTAUDIO_DEV_DSP "/dev/sound/dsp" > > @@ -72,12 +72,12 @@ MODULE_PARM_DESC(mixer, MIXER_HELP); > > static ssize_t hostaudio_read(struct file *file, char __user *buffer, > > size_t count, loff_t *ppos) > > { > > - struct hostaudio_state *state = file->private_data; > > + struct hostaudio_state *state = file->private_data; > > void *kbuf; > > int err; > > > > #ifdef DEBUG > > - printk("hostaudio: read called, count = %d\n", count); > > + printk("hostaudio: read called, count = %d\n", count); > > #endif > > > > kbuf = kmalloc(count, GFP_KERNEL); > > @@ -91,7 +91,7 @@ static ssize_t hostaudio_read(struct fil > > if(copy_to_user(buffer, kbuf, err)) > > err = -EFAULT; > > > > - out: > > +out: > > > Isn't labels _suppose_ to be spaced? (due to "grep", if I'm not mistaken)... There was some noise about that (due to 'patch' IIRC). I tested it and could not cause a problem with labels beginning in column 0. Can you? > > kfree(kbuf); > > return(err); > > } --- ~Randy ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel