From: Blaisorblade <blaisorblade@yahoo.it>
To: Jeff Dike <jdike@addtoit.com>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] When opening /tmp/uml.ctl fails, what do we get?
Date: Mon, 5 Mar 2007 19:27:44 +0100 [thread overview]
Message-ID: <200703051927.44601.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20070305155126.GA4717@ccure.user-mode-linux.org>
On Monday 05 March 2007 16:51, Jeff Dike wrote:
> On Sun, Mar 04, 2007 at 08:13:39PM +0100, Blaisorblade wrote:
> > Have you checked if other calls require that register_netdev was already
> > called?
>
> Just did, nothing else depends on it.
Fine.
> > Hmm, I'm really not sure about what to do about this. However I'd leave
> > that for a future cleanup and just add a comment about this.
> > And the reason for which init now returns a value is that pcap_init _can_
> > fail, so the switch transport is not the only odd one.
>
> Yeah, that slipped my mind.
>
> > struct uml_net_private {
> > - int user[1];
> > + char user[0];
> > };
>
> Neat, that used to be illegal.
If you use -pedantic (-ansi -std=c89 doesn't suffice) you'll learn that ISO C
prohibits that; however, ethtool.h is quite a good example I guess, so GCC
3.2 supports that; and the code is anyway simpler that way.
--
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
prev parent reply other threads:[~2007-03-05 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 23:54 [uml-devel] When opening /tmp/uml.ctl fails, what do we get? Blaisorblade
2007-02-22 17:42 ` Jeff Dike
2007-02-22 19:59 ` Jeff Dike
2007-03-04 19:13 ` Blaisorblade
2007-03-05 15:51 ` Jeff Dike
2007-03-05 18:27 ` Blaisorblade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703051927.44601.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).