From: Jeff Dike <jdike@addtoit.com>
To: Rob Landley <rob@landley.net>
Cc: uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [uml-devel] UML doesn't build in 2.6.23-rc3.
Date: Wed, 22 Aug 2007 17:31:15 -0400 [thread overview]
Message-ID: <20070822213115.GB14287@c2.user-mode-linux.org> (raw)
In-Reply-To: <200708221626.53510.rob@landley.net>
On Wed, Aug 22, 2007 at 04:26:53PM -0500, Rob Landley wrote:
> include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
> include/asm-generic/tlb.h:76: error: implicit declaration of
> function ‘release_pages’
> include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
> include/asm-generic/tlb.h:105: error: implicit declaration of
> function ‘page_cache_release’
Shouldn't the new include go in asm-generic/tlb.h instead?
Index: linux-2.6.22/include/asm-generic/tlb.h
===================================================================
--- linux-2.6.22.orig/include/asm-generic/tlb.h 2007-07-08 19:32:17.000000000 -0400
+++ linux-2.6.22/include/asm-generic/tlb.h 2007-08-22 17:29:45.000000000 -0400
@@ -13,6 +13,7 @@
#ifndef _ASM_GENERIC__TLB_H
#define _ASM_GENERIC__TLB_H
+#include <linux/pagemap.h>
#include <linux/swap.h>
#include <asm/pgalloc.h>
#include <asm/tlbflush.h>
This doesn't cause any obvious problems, but then I wasn't seeing the
build failure in the first place.
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2007-08-22 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 2:48 [uml-devel] UML doesn't build in 2.6.23-rc3 Rob Landley
2007-08-22 17:24 ` Jeff Dike
2007-08-22 21:26 ` Rob Landley
2007-08-22 21:31 ` Jeff Dike [this message]
2007-08-23 1:47 ` Rob Landley
2007-08-23 3:44 ` Jeff Dike
2007-09-04 12:37 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822213115.GB14287@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=rob@landley.net \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox