From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>, Joe Perches <joe@perches.com>,
Jeff Dike <jdike@addtoit.com>,
LKML <linux-kernel@vger.kernel.org>,
Satyam Sharma <satyam@infradead.org>
Subject: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
Date: Thu, 23 Aug 2007 16:54:59 +0200 [thread overview]
Message-ID: <200708231655.00034.blaisorblade@yahoo.it> (raw)
In-Reply-To: <alpine.LFD.0.999.0708181924020.29105@enigma.security.iitk.ac.in>
[-- Attachment #1.1: Type: text/plain, Size: 922 bytes --]
On sabato 18 agosto 2007, Satyam Sharma wrote:
> On Fri, 17 Aug 2007, Jeff Dike wrote:
> > Style fixes in hostfs.
> > @@ -328,17 +326,17 @@ int hostfs_readdir(struct file *file, vo
> > [...]
> > - if(error) break;
> > + if (error) break;
>
> if (error)
> break;
>
> > @@ -522,28 +523,28 @@ static int init_inode(struct inode *inod
> > [...]
> > else type = OS_TYPE_DIR;
>
> I wonder what's the generally accepted / followed coding style for this,
> actually. Personally I'd prefer:
>
> else
> type = OS_TYPE_DIR;
I strongly agree with this style; beyond style itself, one strong reason is
that joining statements hinder singlestepping through function code (it's
easy to run gdb on UML, and anyway kgdb exists).
Bye
--
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 315 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
[-- Attachment #3: Type: text/plain, Size: 194 bytes --]
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2007-08-23 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 19:43 [uml-devel] [PATCH 6/6] UML - Fix hostfs style Jeff Dike
2007-08-18 14:19 ` Satyam Sharma
2007-08-23 14:54 ` Blaisorblade [this message]
2007-08-24 15:21 ` Jeff Dike
2007-08-24 16:10 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708231655.00034.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox