linux-um archives
 help / color / mirror / Atom feed
From: Eric Sesterhenn <snakebyte@gmx.de>
To: xiyou.wangcong@gmail.com
Cc: user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com,
	linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [uml-devel] [Patch] um: fix a build error
Date: Tue, 22 Jul 2008 12:58:12 +0200	[thread overview]
Message-ID: <20080722105812.GB5283@alice> (raw)

I just ran across the same build error, does
something like this look reasonable? Only build
and boot tested.

This fixes the following build error:

  CC      arch/um/drivers/line.o
  arch/um/drivers/line.c: In function ‘line_write_interrupt’:
  arch/um/drivers/line.c:366: error: ‘struct tty_ldisc’ has no member
  named ‘write_wakeup’
  arch/um/drivers/line.c:367: error: ‘struct tty_ldisc’ has no member
  named ‘write_wakeup’
  make[1]: *** [arch/um/drivers/line.o] Error 1
  make: *** [arch/um/drivers] Error 2


Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6/arch/um/drivers/line.c.orig	2008-07-22 12:06:17.000000000 +0200
+++ linux-2.6/arch/um/drivers/line.c	2008-07-22 12:06:49.000000000 +0200
@@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt(
 	if (tty == NULL)
 		return IRQ_NONE;
 
-	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
-	   (tty->ldisc.write_wakeup != NULL))
-		(tty->ldisc.write_wakeup)(tty);
-
+	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
+		tty_wakeup(tty);
 	/*
 	 * BLOCKING mode
 	 * In blocking mode, everything sleeps on tty->write_wait.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

             reply	other threads:[~2008-07-22 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 10:58 Eric Sesterhenn [this message]
2008-07-22 10:53 ` [uml-devel] [Patch] um: fix a build error Alan Cox
2008-07-22 11:25   ` WANG Cong
2008-07-22 17:35   ` WANG Cong
2008-07-22 17:42     ` Alan Cox
     [not found] <1434379436-8301-1-git-send-email-firogm@gmail.com>
2015-06-15 14:49 ` [uml-devel] [PATCH] um: Fix " Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2008-07-21 16:54 [uml-devel] [Patch] um: fix " WANG Cong
2008-07-21 16:32 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080722105812.GB5283@alice \
    --to=snakebyte@gmx.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox