linux-um archives
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@linuxfoundation.org, torvalds@linux-foundation.org,
	stable@kernel.org, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH] UML - Fix boot crash
Date: Wed, 23 Jul 2008 12:59:25 -0700	[thread overview]
Message-ID: <20080723125925.6ac68198.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080723154650.GA15682@c2.user-mode-linux.org>

On Wed, 23 Jul 2008 11:46:50 -0400
Jeff Dike <jdike@addtoit.com> wrote:

> My copying of linux/init.h didn't go far enough.  The definition of
> __used singled out gcc minor version 3, but didn't care what the major
> version was.  This broke when unit-at-a-time was added and gcc started
> throwing out initcalls.
> 
> This results in an early boot crash when ptrace tries to initialize a
> process with an empty, uninitialized register set.
> 
> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
> ---
>  arch/um/include/init.h |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> Index: linux-2.6.22/arch/um/include/init.h
> ===================================================================
> --- linux-2.6.22.orig/arch/um/include/init.h	2008-02-18 11:53:50.000000000 -0500
> +++ linux-2.6.22/arch/um/include/init.h	2008-07-20 18:06:35.000000000 -0400
> @@ -45,6 +45,8 @@ typedef void (*exitcall_t)(void);
>  # define __section(S) __attribute__ ((__section__(#S)))
>  #endif
>  
> +#if __GNUC__ == 3
> +
>  #if __GNUC_MINOR__ >= 3
>  # define __used			__attribute__((__used__))
>  #else
> @@ -52,6 +54,12 @@ typedef void (*exitcall_t)(void);
>  #endif
>  
>  #else
> +#if __GNUC__ == 4
> +# define __used			__attribute__((__used__))
> +#endif
> +#endif
> +
> +#else
>  #include <linux/compiler.h>
>  #endif
>  /* These are for everybody (although not all archs will actually

Needed in 2.6.26.x, but also applies to 2.6.25.  Is it also needed in
2.6.25.x?


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2008-07-23 19:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 15:46 [uml-devel] [PATCH] UML - Fix boot crash Jeff Dike
2008-07-23 19:59 ` Andrew Morton [this message]
2008-07-24  2:49   ` Jeff Dike
2008-07-24  2:52   ` Jeff Dike
2008-07-24 15:32     ` [uml-devel] [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080723125925.6ac68198.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=akpm@linuxfoundation.org \
    --cc=jdike@addtoit.com \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox