From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 8 Nov 2009 16:50:00 +0000 From: Alan Cox Message-ID: <20091108165000.374714cb@lxorguk.ukuu.org.uk> In-Reply-To: References: Mime-Version: 1.0 Subject: Re: [uml-devel] [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-14" Content-Transfer-Encoding: quoted-printable Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: =?ISO-8859-14?B?QW5kcuk=?= Goddard Rosa Cc: Andreas Dilger , Mike Snitzer , Takashi Iwai , Kysela , Jan@nerdnet.nl, Stefan Weinhuber , Eric Sandeen , "James E ." J.Bottomley" ," linux-cachefs@redhat.com, WANG Cong , Len Brown , Trond Myklebust , Rusty Russell , netfilter@vger.kernel.org, Al Viro , Thomas Gleixner , Engelhardt , Bjorn Helgaas , =?ISO-8859-14?B?QW5k?=@nerdnet.nl, "Martin K ." Petersen" ," linux-kernel@vger.kernel.org, Stoyan Gaydarov , Kyle McMartin , netfilter-devel@vger.kernel.org, Joe Perches , Andrew Morton , Patrick McHardy , alsa-devel@alsa-project.org, dm-devel@redhat.com, Jaroslav@nerdnet.nl, Kergon , Banks , linux-s390@vger.kernel.org, Helge Deller , Samuel@nerdnet.nl, coreteam@netfilter.org, Michael Holzheu , van de Ven , Theodore Ts'o , Jason Baron , Steve@nerdnet.nl, Christof Schmitt , Martin Schwidefsky , linux390@de.ibm.com, Frederic Weisbecker , Heiko Carstens , James Morris , Andre Noll , ibm-acpi-devel@lists.sourceforge.net, Jens Axboe , Adam Belay , Stefan Haberland , Roman Hoog Antink , linux-ext4@vger.kernel.org, Alexey Dobriyan , Dike , Henrique de Moraes Holschuh , Steven Rostedt , Pekka Enberg , linux-parisc@vger.kernel.org, Jeff@nerdnet.nl, =?ISO-8859-14?B?cuk=?= Goddard Rosa , Greg Kroah-Hartman , Roel Kluin , Andrey Borzenkov , "David S . Miller , Pavel Roskin" , Jan Kara , Neil Brown , "H . Peter Anvin" , Dickson , David Howells , Julia Lawall , Alasdair@nerdnet.nl, Daire Byrne , x86@kernel.org, Ingo Molnar , Arjan@nerdnet.nl, Andrea Righi , Ortiz , user-mode-linux-devel@lists.sourceforge.net, Sitsofe Wheeler , linux-raid@vger.kernel.org, Greg@nerdnet.nl, Mikulas Patocka , user-mode-linux-user@lists.sourceforge.net, netdev@vger.kernel.org, Richard Purdie On Sat, 7 Nov 2009 13:16:18 -0200 Andr=E9 Goddard Rosa wrote: > On the following sentence: > while (*s && isspace(*s)) > s++; Looks fine but for one thing: it's actually shorter inline than moved into /lib so at the very least it should be a header inline not a function call. Second minor comment. Although it never made it into the final ANSI C, the proposed name (and the one used in a lot of other non Linux code for this) is stpblk(). Alan ---------------------------------------------------------------------------= --- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day = trial. Simplify your report design, integration and deployment - and focus = on = what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel