Re: [uml-devel] [PATCH] um: Fix IRQ flag handling naming

[Richard Weinberger <richard@nod.at>]

Am Montag 25 Oktober 2010, 21:29:36 schrieb Andrew Morton:
> On Mon, 25 Oct 2010 17:24:33 +0200
> 
> Richard Weinberger <richard@nod.at> wrote:
> > Commit df9ee292 changed the IRQ flag handling naming scheme
> > and broke UML.
> > This patch brings the new scheme to UML and makes it work again.
> 
> Please always fully describe a bug when fixing it.  Something more than
> "broke".  In the case of compilation errors or warnings, that means
> quoting the compiler error output and, if necessary, the means of
> reproducing it (config, compiler version, etc).

Sorry!
I forgot to add the LKML-Reference to my initial report.

LKML-Reference: <201010190141.10365.richard () nod ! at>
 
> I did an allnoconfig uml build and saw this:
> 
> In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5,
>                  from /usr/src/25/arch/um/include/shared/um_uaccess.h:10,
>                  from /usr/src/25/arch/um/include/asm/uaccess.h:41,
>                  from /usr/src/25/arch/um/include/asm/thread_info.h:13,
>                  from include/linux/thread_info.h:56,
>                  from include/linux/preempt.h:9,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/seqlock.h:29,
>                  from include/linux/time.h:8,
>                  from include/linux/stat.h:60,
>                  from include/linux/module.h:10,
>                  from init/main.c:13:
> /usr/src/25/arch/um/include/asm/system.h:11:1: warning: "local_save_flags"
> redefined
> 
> which I shall assume is the error which this patch addresses.

Yes, this is the error.

Thanks,
//richard

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel