From: Steven Rostedt <rostedt@goodmis.org>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: kernel 2.6.39 (user mode linux) crashes (2.6.38 works fine)
Date: Thu, 19 May 2011 16:43:43 -0400 [thread overview]
Message-ID: <20110519204342.GA10792@home.goodmis.org> (raw)
In-Reply-To: <201105192218.18261.toralf.foerster@gmx.de>
On Thu, May 19, 2011 at 10:18:16PM +0200, Toralf Förster wrote:
>
> richard -rw- weinberger wrote at 19:00:35
> > Can you bisect the issue?
Is this bug fully reproducable? If not, then you may have had a git
bisect good, when it should have been git bisect bad.
The futex/plist should not be affecting rwsem.
-- Steve
>
> tfoerste@n22 ~/devel/linux-2.6 $ git bisect bad
> 2e12978a9f7a7abd54e8eb9ce70a7718767b8b2c is the first bad commit
> commit 2e12978a9f7a7abd54e8eb9ce70a7718767b8b2c
> Author: Lai Jiangshan <laijs@cn.fujitsu.com>
> Date: Wed Dec 22 14:18:50 2010 +0800
>
> futex,plist: Pass the real head of the priority list to plist_del()
>
> Some plist_del()s in kernel/futex.c are passed a faked head of the
> priority list.
>
> It does not fail because the current code does not require the real head
> in plist_del(). The current code of plist_del() just uses the head for
> checking,
> so it will not cause a bad result even when we use a faked head.
>
> But it is undocumented usage:
>
> /**
> * plist_del - Remove a @node from plist.
> *
> * @node: &struct plist_node pointer - entry to be removed
> * @head: &struct plist_head pointer - list head
> */
>
> The document says that the @head is the "list head" head of the priority
> list.
>
> In futex code, several places use "plist_del(&q->list, &q->list.plist);",
> they pass a fake head. We need to fix them all.
>
> Thanks to Darren Hart for many suggestions.
>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> LKML-Reference: <4D11984A.5030203@cn.fujitsu.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> :040000 040000 78d47de377f8da1c131007a17ca915fbd13f7ff6
> ffac93205aaf22fda0667d6395c8da7c7bf692e4 M kernel
>
> --
> MfG/Sincerely
> Toralf Förster
> pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-05-19 20:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201105191526.31904.toralf.foerster@gmx.de>
2011-05-19 17:00 ` kernel 2.6.39 (user mode linux) crashes (2.6.38 works fine) richard -rw- weinberger
2011-05-19 17:20 ` Toralf Förster
2011-05-19 17:25 ` richard -rw- weinberger
2011-05-19 20:18 ` Toralf Förster
2011-05-19 20:43 ` Steven Rostedt [this message]
2011-05-20 7:37 ` Toralf Förster
2011-05-20 7:56 ` richard -rw- weinberger
2011-05-20 8:39 ` richard -rw- weinberger
2011-05-20 8:58 ` Toralf Förster
2011-05-20 9:02 ` richard -rw- weinberger
2011-05-20 9:19 ` Toralf Förster
2011-05-20 8:42 ` Toralf Förster
2011-05-20 16:24 ` richard -rw- weinberger
2011-05-20 17:19 ` Steven Rostedt
2011-05-20 15:55 ` Darren Hart
2011-05-20 16:04 ` Steven Rostedt
2011-05-20 16:11 ` Steven Rostedt
2011-05-20 17:10 ` Toralf Förster
2011-05-20 17:44 ` Steven Rostedt
2011-05-20 17:46 ` Steven Rostedt
2011-05-20 22:53 ` Toralf Förster
2011-05-21 8:53 ` Toralf Förster
2011-05-23 19:17 ` richard -rw- weinberger
2011-05-23 19:48 ` Toralf Förster
2011-05-21 10:12 ` richard -rw- weinberger
2011-05-21 22:37 ` Peter Zijlstra
2011-05-21 23:06 ` richard -rw- weinberger
2011-05-20 17:35 ` Darren Hart
2011-05-20 17:41 ` Steven Rostedt
[not found] ` <201105191834.56577.toralf.foerster@gmx.de>
2011-05-20 6:44 ` richard -rw- weinberger
2011-05-20 7:43 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519204342.GA10792@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=toralf.foerster@gmx.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox