linux-um archives
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: user-mode-linux-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 5/7] um: print info about fatal segfaults
Date: Tue, 24 May 2011 22:14:20 +0200	[thread overview]
Message-ID: <201105242214.21102.richard@nod.at> (raw)
In-Reply-To: <20110524123433.0b74f33e.akpm@linux-foundation.org>

Am Dienstag 24 Mai 2011, 21:34:33 schrieb Andrew Morton:
> Please see the nice comment in printk.h
> 
> /*
>  * Please don't use printk_ratelimit(), because it shares ratelimiting
> state * with all other unrelated printk_ratelimit() callsites.  Instead
> use * printk_ratelimited() or plain old __ratelimit().
>  */
> 
> I thought we had a checkpatch rule for this but apparently I dreamed
> it.

Hmm, it seems I'm not the only one who doesn't know that. :-\
rw@raccoon:/media/data1/linux-2.6 (master)> grep * -R -e "printk_ratelimit()" | wc -l
243

Anyway, will resend...

Thanks,
//richard

  parent reply	other threads:[~2011-05-24 20:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 14:48 [PATCH 1/7] um: fix UML_LIB_PATH Richard Weinberger
2011-05-22 14:48 ` [uml-devel] [PATCH 2/7] um: remove SIGHUP handler Richard Weinberger
2011-05-22 14:48 ` [uml-devel] [PATCH 3/7] um: add earlyprintk support Richard Weinberger
2011-05-22 14:48 ` [uml-devel] [PATCH 4/7] um: add ucast ethernet transport Richard Weinberger
2011-05-22 14:48 ` [uml-devel] [PATCH 5/7] um: print info about fatal segfaults Richard Weinberger
2011-05-24 19:34   ` Andrew Morton
2011-05-24 20:02     ` [uml-devel] [PATCH] checkpatch: Add warning for uses of printk_ratelimit Joe Perches
2011-05-24 20:14     ` Richard Weinberger [this message]
2011-05-22 14:48 ` [uml-devel] [PATCH 6/7] um: include linux/prefetch.h Richard Weinberger
2011-05-22 14:48 ` [uml-devel] [PATCH 7/7] um: fix crash while os_dump_core() Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105242214.21102.richard@nod.at \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox