From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 12 Dec 2012 23:45:50 +0100 From: Borislav Petkov Message-ID: <20121212224550.GJ8760@liondog.tnic> References: <054f8a88fe46ae0b4c2669d0e155d84c11b66115.1355335228.git.joe@perches.com> <20121212210959.GH8760@liondog.tnic> <1355347803.8538.16.camel@joe-AO722> <3908561D78D1C84285E8C5FCA982C28F1C969495@ORSMSX108.amr.corp.intel.com> <1355351039.27571.2.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1355351039.27571.2.camel@joe-AO722> Sender: linux-kernel-owner@vger.kernel.org Subject: Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR To: Joe Perches Cc: "Luck, Tony" , Jiri Kosina , Jeff Dike , Richard Weinberger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "user-mode-linux-user@lists.sourceforge.net" List-ID: On Wed, Dec 12, 2012 at 02:23:59PM -0800, Joe Perches wrote: > On Wed, 2012-12-12 at 21:49 +0000, Luck, Tony wrote: > > > I think I'd go ahead and ACK this unless Tony has some comments. I'm not > > > happy about the two pr_emerg calls based on the conditional. > > > > As written the patch has the nice property of not making any changes to the > > console output (except to eliminate the possibility of interleaved output that > > the original code had). > > Well, it does eliminate a trailing space when m->cs != KERNEL_CS. > That probably won't hurt anything, but... Yeah, that won't be an issue. So let's take it as is, as Tony suggests. Acked-by: Borislav Petkov Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --