From: Richard Guy Briggs <rgb@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-audit@redhat.com, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 2/4] UM: implement syscall_get_arch()
Date: Fri, 21 Mar 2014 15:22:57 -0400 [thread overview]
Message-ID: <20140321192257.GG16467@madcap2.tricolour.ca> (raw)
In-Reply-To: <20140321190803.GD16467@madcap2.tricolour.ca>
On 14/03/21, Richard Guy Briggs wrote:
> On 14/03/19, Eric Paris wrote:
> > SH: define syscall_get_arch() for superh
> >
> > This patch defines syscall_get_arch() for the um platform. It adds a
> > new syscall.h header file to define this. It copies the HOST_AUDIT_ARCH
> > definition from ptrace.h. (that definition will be removed when we
> > switch audit to use this new syscall_get_arch() function)
>
> Why not just use:
Sorry, I see now that you yanked it out of ptrace.h.
> diff --git a/arch/um/include/asm/syscall.h
> b/arch/um/include/asm/syscall.h
> new file mode 100644
> index 0000000..fbcb2e4
> --- /dev/null
> +++ b/arch/um/include/asm/syscall.h
> @@ -0,0 +1,9 @@
> +#ifndef __ASM_UM_SYSCALL_H
> +#define __ASM_UM_SYSCALL_H
> +
> +static inline int syscall_get_arch(void)
> +{
> + return HOST_AUDIT_ARCH;
> +}
> +
> +#endif /* __ASM_SH_SYSCALL_H */
>
> > Signed-off-by: Eric Paris <eparis@redhat.com>
> > Cc: user-mode-linux-devel@lists.sourceforge.net
> > ---
> > arch/x86/um/asm/syscall.h | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> > create mode 100644 arch/x86/um/asm/syscall.h
> >
> > diff --git a/arch/x86/um/asm/syscall.h b/arch/x86/um/asm/syscall.h
> > new file mode 100644
> > index 0000000..9fe77b7
> > --- /dev/null
> > +++ b/arch/x86/um/asm/syscall.h
> > @@ -0,0 +1,15 @@
> > +#ifndef __UM_ASM_SYSCALL_H
> > +#define __UM_ASM_SYSCALL_H
> > +
> > +#include <uapi/linux/audit.h>
> > +
> > +static inline int syscall_get_arch(void)
> > +{
> > +#ifdef CONFIG_X86_32
> > + return AUDIT_ARCH_I386;
> > +#else
> > + return AUDIT_ARCH_X86_64;
> > +#endif
> > +}
> > +
> > +#endif /* __UM_ASM_SYSCALL_H */
> > --
> > 1.8.5.3
> >
> > --
> > Linux-audit mailing list
> > Linux-audit@redhat.com
> > https://www.redhat.com/mailman/listinfo/linux-audit
>
> - RGB
>
> --
> Richard Guy Briggs <rbriggs@redhat.com>
> Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
> Remote, Ottawa, Canada
> Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2014-03-21 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1395266643-3139-1-git-send-email-eparis@redhat.com>
2014-03-19 22:04 ` [uml-devel] [PATCH 2/4] UM: implement syscall_get_arch() Eric Paris
2014-03-21 19:08 ` Richard Guy Briggs
2014-03-21 19:22 ` Richard Guy Briggs [this message]
2014-03-24 1:03 ` Eric Paris
2014-03-21 19:24 ` Richard Guy Briggs
2014-03-19 22:04 ` [PATCH 4/4] ARCH: AUDIT: audit_syscall_entry() should not require the arch Eric Paris
2014-03-21 19:18 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321192257.GG16467@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox