From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 19 Jul 2014 17:03:16 +0530 From: Himangi Saraogi Message-ID: <20140719113316.GA23543@himangi-Dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Subject: [PATCH] uml: Eliminate NULL test after alloc_bootmem To: Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: Julia Lawall List-ID: alloc_bootmem and related functions never return NULL. Thus a NULL test after calls to these functions is unnecessary. The following Coccinelle semantic patch was used for making the change: @@ expression E; statement S; @@ E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...) ... when != E - if (E == NULL) S Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- arch/um/kernel/initrd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/um/kernel/initrd.c b/arch/um/kernel/initrd.c index 55cead8..48bae81 100644 --- a/arch/um/kernel/initrd.c +++ b/arch/um/kernel/initrd.c @@ -37,8 +37,6 @@ static int __init read_initrd(void) } area = alloc_bootmem(size); - if (area == NULL) - return 0; if (load_initrd(initrd, area, size) == -1) return 0; -- 1.9.1