From: Josh Triplett <josh@joshtriplett.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: linux-kernel@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
user-mode-linux-devel@lists.sourceforge.net,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Michal Marek <mmarek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] um: Fix build error and kconfig for i386
Date: Thu, 24 Dec 2015 17:26:13 -0800 [thread overview]
Message-ID: <20151225012613.GA12977@x> (raw)
In-Reply-To: <567BE089.8030903@digikod.net>
On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote:
>
> On 23/12/2015 22:42, Josh Triplett wrote:
> > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
> >> Fix build error by selecting COREDUMP when X86_32 is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> >> Cc: Jeff Dike <jdike@addtoit.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Josh Triplett <josh@joshtriplett.org>
> >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >> Cc: Michal Marek <mmarek@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> >
> > I suppose um doesn't care deeply about binary size, but ideally I would
> > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>
> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
-mm regularly replaces patches with newer versions, so that ought to be
fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-12-25 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:59 [PATCH v2] um: Fix build error and kconfig for i386 Mickaël Salaün
2015-12-23 21:42 ` Josh Triplett
2015-12-24 12:09 ` Mickaël Salaün
2015-12-25 1:26 ` Josh Triplett [this message]
2015-12-25 15:10 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151225012613.GA12977@x \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=mmarek@suse.cz \
--cc=paulmck@linux.vnet.ibm.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).