From: Josh Triplett <josh@joshtriplett.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: linux-kernel@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
user-mode-linux-devel@lists.sourceforge.net,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Michal Marek <mmarek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] um: Fix build error and kconfig for i386
Date: Thu, 24 Dec 2015 17:34:09 -0800 [thread overview]
Message-ID: <20151225013409.GC12977@x> (raw)
In-Reply-To: <1450959131-5113-1-git-send-email-mic@digikod.net>
On Thu, Dec 24, 2015 at 01:12:11PM +0100, Mickaël Salaün wrote:
> Fix build error by generating elfcore.o only when ELF_CORE (depending on
> COREDUMP) is selected:
>
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
>
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
It looks like ELF_CORE depends on COREDUMP, but not on BINFMT_ELF.
Should it? What happens if you build this with ELF_CORE=y and
BINFMT_ELF=n? Does that configuration even make sense?
> arch/x86/um/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile
> index a8fecc226946..3ee2bb6b440b 100644
> --- a/arch/x86/um/Makefile
> +++ b/arch/x86/um/Makefile
> @@ -17,7 +17,7 @@ obj-y = bug.o bugs_$(BITS).o delay.o fault.o ksyms.o ldt.o \
> ifeq ($(CONFIG_X86_32),y)
>
> obj-y += checksum_32.o
> -obj-$(CONFIG_BINFMT_ELF) += elfcore.o
> +obj-$(CONFIG_ELF_CORE) += elfcore.o
>
> subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o
> subarch-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += ../lib/rwsem.o
> --
> 2.6.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-12-25 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 12:12 [PATCH v3] um: Fix build error and kconfig for i386 Mickaël Salaün
2015-12-25 1:34 ` Josh Triplett [this message]
2015-12-25 18:45 ` Mickaël Salaün
2015-12-26 4:10 ` Josh Triplett
2016-01-10 20:20 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151225013409.GC12977@x \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=mmarek@suse.cz \
--cc=paulmck@linux.vnet.ibm.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).