* [PATCH] um: Fix _print_addr()
@ 2016-12-25 22:11 Richard Weinberger
2017-05-03 20:55 ` [uml-devel] [uml-user] " Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Richard Weinberger @ 2016-12-25 22:11 UTC (permalink / raw)
To: user-mode-linux-devel
Cc: user-mode-linux-user, linux-kernel, Richard Weinberger
Recent changes to printk() broke UML's stack trace
output. Kill the root of the problem by using a single
printk() statement.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/um/kernel/sysrq.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index aa1b56f5ac68..18eddf677ec6 100644
--- a/arch/um/kernel/sysrq.c
+++ b/arch/um/kernel/sysrq.c
@@ -17,10 +17,8 @@
static void _print_addr(void *data, unsigned long address, int reliable)
{
- pr_info(" [<%08lx>]", address);
- pr_cont(" %s", reliable ? "" : "? ");
- print_symbol("%s", address);
- pr_cont("\n");
+ pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
+ (void *)address);
}
static const struct stacktrace_ops stackops = {
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [uml-devel] [uml-user] [PATCH] um: Fix _print_addr()
2016-12-25 22:11 [PATCH] um: Fix _print_addr() Richard Weinberger
@ 2017-05-03 20:55 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2017-05-03 20:55 UTC (permalink / raw)
To: Richard Weinberger
Cc: user-mode-linux-user@lists.sourceforge.net, LKML,
user-mode-linux-devel@lists.sourceforge.net
On Sun, Dec 25, 2016 at 11:11 PM, Richard Weinberger <richard@nod.at> wrote:
> Recent changes to printk() broke UML's stack trace
> output. Kill the root of the problem by using a single
> printk() statement.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/um/kernel/sysrq.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index aa1b56f5ac68..18eddf677ec6 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -17,10 +17,8 @@
>
> static void _print_addr(void *data, unsigned long address, int reliable)
> {
> - pr_info(" [<%08lx>]", address);
> - pr_cont(" %s", reliable ? "" : "? ");
> - print_symbol("%s", address);
> - pr_cont("\n");
> + pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
> + (void *)address);
> }
>
> static const struct stacktrace_ops stackops = {
Applied.
--
Thanks,
//richard
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-03 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-25 22:11 [PATCH] um: Fix _print_addr() Richard Weinberger
2017-05-03 20:55 ` [uml-devel] [uml-user] " Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).