From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: user-mode-linux-devel@lists.sourceforge.net,
Neil Armstrong <narmstrong@baylibre.com>,
Richard Weinberger <richard@nod.at>,
Jeff Dike <jdike@addtoit.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM
Date: Tue, 3 Jan 2017 09:20:04 +0100 [thread overview]
Message-ID: <20170103092004.6edd6e3e@bbrezillon> (raw)
In-Reply-To: <8a756f24-4c18-690c-b898-03ecf3d71c84@infradead.org>
On Sun, 1 Jan 2017 18:58:27 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors on arch/um, which does not support HAS_IOMEM,
> while the oxnas_nand.c driver uses interfaces that are
> supplied by HAS_IOMEM.
>
> (loadable module build:)
> ERROR: "devm_ioremap_resource" [drivers/mtd/nand/oxnas_nand.ko] undefined!
> or (built-in build:)
> drivers/built-in.o: In function `oxnas_nand_probe':
> drivers/mtd/nand/oxnas_nand.c:102: undefined reference to `devm_ioremap_resource'
Applied to nand/fixes. It should appear in one of the next -rc
(probably not -rc3 though).
Thanks,
Boris
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-410-rc2.orig/drivers/mtd/nand/Kconfig
> +++ lnx-410-rc2/drivers/mtd/nand/Kconfig
> @@ -426,6 +426,7 @@ config MTD_NAND_ORION
>
> config MTD_NAND_OXNAS
> tristate "NAND Flash support for Oxford Semiconductor SoC"
> + depends on HAS_IOMEM
> help
> This enables the NAND flash controller on Oxford Semiconductor SoCs.
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2017-01-03 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 2:58 [uml-devel] [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM Randy Dunlap
2017-01-02 8:33 ` Neil Armstrong
2017-01-03 8:20 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103092004.6edd6e3e@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=fengguang.wu@intel.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).