* [PATCH 4/5] x86/um: thin archives build fix
[not found] <20170609052417.561-1-npiggin@gmail.com>
@ 2017-06-09 5:24 ` Nicholas Piggin
2017-06-19 6:21 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Piggin @ 2017-06-09 5:24 UTC (permalink / raw)
To: linux-kbuild, linux-arch
Cc: Nicholas Piggin, Masahiro Yamada, Michal Marek, Linus Torvalds,
Stephen Rothwell, Jeff Dike, Richard Weinberger,
user-mode-linux-devel
The linker does not like vdso-syms.lds in input archive files.
Make it an extra-y instead.
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
Arch maintainers please give an ack if we can take this through
the kbuild tree.
Thanks,
Nick
arch/x86/um/vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
index d72dec406ccb..329406224330 100644
--- a/arch/x86/um/vdso/Makefile
+++ b/arch/x86/um/vdso/Makefile
@@ -53,7 +53,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg -fprofile-arcs -ftest-coverage
CFLAGS_REMOVE_um_vdso.o = -pg -fprofile-arcs -ftest-coverage
targets += vdso-syms.lds
-obj-$(VDSO64-y) += vdso-syms.lds
+extra-$(VDSO64-y) += vdso-syms.lds
#
# Match symbols in the DSO that look like VDSO*; produce a file of constants.
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/5] x86/um: thin archives build fix
2017-06-09 5:24 ` [PATCH 4/5] x86/um: thin archives build fix Nicholas Piggin
@ 2017-06-19 6:21 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2017-06-19 6:21 UTC (permalink / raw)
To: Nicholas Piggin
Cc: Linux Kbuild mailing list, linux-arch, Michal Marek,
Linus Torvalds, Stephen Rothwell, Jeff Dike, Richard Weinberger,
user-mode-linux-devel
2017-06-09 14:24 GMT+09:00 Nicholas Piggin <npiggin@gmail.com>:
> The linker does not like vdso-syms.lds in input archive files.
> Make it an extra-y instead.
>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>
> Arch maintainers please give an ack if we can take this through
> the kbuild tree.
>
> Thanks,
> Nick
>
> arch/x86/um/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
> index d72dec406ccb..329406224330 100644
> --- a/arch/x86/um/vdso/Makefile
> +++ b/arch/x86/um/vdso/Makefile
> @@ -53,7 +53,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg -fprofile-arcs -ftest-coverage
> CFLAGS_REMOVE_um_vdso.o = -pg -fprofile-arcs -ftest-coverage
>
> targets += vdso-syms.lds
> -obj-$(VDSO64-y) += vdso-syms.lds
> +extra-$(VDSO64-y) += vdso-syms.lds
I agree this line is weird, but where is vdso-syms.lds used?
I removed the following, but it still built successfully.
targets += vdso-syms.lds
obj-$(VDSO64-y) += vdso-syms.lds
$(obj)/%-syms.lds: $(obj)/%.so.dbg FORCE
$(call if_changed,vdsosym)
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-19 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170609052417.561-1-npiggin@gmail.com>
2017-06-09 5:24 ` [PATCH 4/5] x86/um: thin archives build fix Nicholas Piggin
2017-06-19 6:21 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox