* [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses
[not found] <1504729681-3504-1-git-send-email-deller@gmx.de>
@ 2017-09-06 20:27 ` Helge Deller
2017-09-12 12:10 ` Petr Mladek
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2017-09-06 20:27 UTC (permalink / raw)
To: linux-kernel
Cc: Sergey Senozhatsky, Petr Mladek, Andrew Morton, Jeff Dike,
Richard Weinberger, user-mode-linux-devel
Use the %pS printk format for printing symbols from direct addresses.
In usermode-linux there is actually no difference between %pS and %pF, but for
consistency throughout the kernel fix the wrong usage here too.
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
---
arch/um/kernel/sysrq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index 6b995e8..05585ee 100644
--- a/arch/um/kernel/sysrq.c
+++ b/arch/um/kernel/sysrq.c
@@ -20,7 +20,7 @@
static void _print_addr(void *data, unsigned long address, int reliable)
{
- pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
+ pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ",
(void *)address);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses
2017-09-06 20:27 ` [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses Helge Deller
@ 2017-09-12 12:10 ` Petr Mladek
2017-09-21 20:13 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Petr Mladek @ 2017-09-12 12:10 UTC (permalink / raw)
To: Helge Deller
Cc: linux-kernel, Sergey Senozhatsky, Andrew Morton, Jeff Dike,
Richard Weinberger, user-mode-linux-devel
On Wed 2017-09-06 22:27:49, Helge Deller wrote:
> Use the %pS printk format for printing symbols from direct addresses.
> In usermode-linux there is actually no difference between %pS and %pF, but for
> consistency throughout the kernel fix the wrong usage here too.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: user-mode-linux-devel@lists.sourceforge.net
> ---
> arch/um/kernel/sysrq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index 6b995e8..05585ee 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -20,7 +20,7 @@
>
> static void _print_addr(void *data, unsigned long address, int reliable)
> {
> - pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
> + pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ",
> (void *)address);
This seems to be used to print addresses from the stack.
IMHO, we should use %pB here.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses
2017-09-12 12:10 ` Petr Mladek
@ 2017-09-21 20:13 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2017-09-21 20:13 UTC (permalink / raw)
To: Petr Mladek
Cc: Helge Deller, LKML, Sergey Senozhatsky, Andrew Morton, Jeff Dike,
Richard Weinberger, user-mode-linux-devel@lists.sourceforge.net
On Tue, Sep 12, 2017 at 2:10 PM, Petr Mladek <pmladek@suse.com> wrote:
> On Wed 2017-09-06 22:27:49, Helge Deller wrote:
>> Use the %pS printk format for printing symbols from direct addresses.
>> In usermode-linux there is actually no difference between %pS and %pF, but for
>> consistency throughout the kernel fix the wrong usage here too.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>> Cc: Jeff Dike <jdike@addtoit.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: user-mode-linux-devel@lists.sourceforge.net
>> ---
>> arch/um/kernel/sysrq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
>> index 6b995e8..05585ee 100644
>> --- a/arch/um/kernel/sysrq.c
>> +++ b/arch/um/kernel/sysrq.c
>> @@ -20,7 +20,7 @@
>>
>> static void _print_addr(void *data, unsigned long address, int reliable)
>> {
>> - pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
>> + pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ",
>> (void *)address);
>
> This seems to be used to print addresses from the stack.
> IMHO, we should use %pB here.
%pWTF? ;)
Agreed, let's use %pB.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-21 20:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1504729681-3504-1-git-send-email-deller@gmx.de>
2017-09-06 20:27 ` [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses Helge Deller
2017-09-12 12:10 ` Petr Mladek
2017-09-21 20:13 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox