linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH AUTOSEL for 3.18 059/101] x86/um: thin archives build fix
       [not found] <20180409004042.164920-1-alexander.levin@microsoft.com>
@ 2018-04-09  0:41 ` Sasha Levin
  2018-04-09  4:29   ` Nicholas Piggin
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2018-04-09  0:41 UTC (permalink / raw)
  To: stable@vger.kernel.org, linux-kernel@vger.kernel.org
  Cc: Nicholas Piggin, Jeff Dike, Richard Weinberger,
	user-mode-linux-devel@lists.sourceforge.net, Masahiro Yamada,
	Sasha Levin

From: Nicholas Piggin <npiggin@gmail.com>

[ Upstream commit 827880ec260ba048f95fe646b96a205c394fa0f0 ]

The linker does not like vdso-syms.lds in input archive files.
Make it an extra-y instead.

Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
 arch/x86/um/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
index 6c803ca49b5d..486f62c3bd04 100644
--- a/arch/x86/um/vdso/Makefile
+++ b/arch/x86/um/vdso/Makefile
@@ -50,7 +50,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg -fprofile-arcs -ftest-coverage
 CFLAGS_REMOVE_um_vdso.o = -pg -fprofile-arcs -ftest-coverage
 
 targets += vdso-syms.lds
-obj-$(VDSO64-y)			+= vdso-syms.lds
+extra-$(VDSO64-y)			+= vdso-syms.lds
 
 #
 # Match symbols in the DSO that look like VDSO*; produce a file of constants.
-- 
2.15.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH AUTOSEL for 3.18 059/101] x86/um: thin archives build fix
  2018-04-09  0:41 ` [PATCH AUTOSEL for 3.18 059/101] x86/um: thin archives build fix Sasha Levin
@ 2018-04-09  4:29   ` Nicholas Piggin
  2018-04-15 15:02     ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Piggin @ 2018-04-09  4:29 UTC (permalink / raw)
  To: Sasha Levin
  Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Dike,
	Richard Weinberger, user-mode-linux-devel@lists.sourceforge.net,
	Masahiro Yamada

On Mon, 9 Apr 2018 00:41:22 +0000
Sasha Levin <Alexander.Levin@microsoft.com> wrote:

> From: Nicholas Piggin <npiggin@gmail.com>
> 
> [ Upstream commit 827880ec260ba048f95fe646b96a205c394fa0f0 ]
> 
> The linker does not like vdso-syms.lds in input archive files.
> Make it an extra-y instead.

I wouldn't say these should be needed on kernels without thin
archives build.

It shouldn't hurt, but no point risking stable breakage.

Thanks,
Nick


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH AUTOSEL for 3.18 059/101] x86/um: thin archives build fix
  2018-04-09  4:29   ` Nicholas Piggin
@ 2018-04-15 15:02     ` Sasha Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2018-04-15 15:02 UTC (permalink / raw)
  To: Nicholas Piggin
  Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Dike,
	Richard Weinberger, user-mode-linux-devel@lists.sourceforge.net,
	Masahiro Yamada

On Mon, Apr 09, 2018 at 02:29:11PM +1000, Nicholas Piggin wrote:
>On Mon, 9 Apr 2018 00:41:22 +0000
>Sasha Levin <Alexander.Levin@microsoft.com> wrote:
>
>> From: Nicholas Piggin <npiggin@gmail.com>
>>
>> [ Upstream commit 827880ec260ba048f95fe646b96a205c394fa0f0 ]
>>
>> The linker does not like vdso-syms.lds in input archive files.
>> Make it an extra-y instead.
>
>I wouldn't say these should be needed on kernels without thin
>archives build.
>
>It shouldn't hurt, but no point risking stable breakage.
>
>Thanks,
>Nick

Now dropped, thanks Nick!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-15 15:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20180409004042.164920-1-alexander.levin@microsoft.com>
2018-04-09  0:41 ` [PATCH AUTOSEL for 3.18 059/101] x86/um: thin archives build fix Sasha Levin
2018-04-09  4:29   ` Nicholas Piggin
2018-04-15 15:02     ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).