From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSnQh-0008Hz-Ld for linux-um@lists.infradead.org; Fri, 30 Nov 2018 18:22:21 +0000 Received: by mail-pg1-f196.google.com with SMTP id g189so2845141pgc.5 for ; Fri, 30 Nov 2018 10:22:09 -0800 (PST) Date: Fri, 30 Nov 2018 10:22:03 -0800 From: Luis Chamberlain Subject: Re: [RFC v3 06/19] arch: um: enable running kunit from User Mode Linux Message-ID: <20181130182203.GS18410@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-7-brendanhiggins@google.com> <20181130033704.GL18410@garbanzo.do-not-panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Rob Herring , Arnd Bergmann Cc: brakmo@fb.com, Brendan Higgins , dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Frank Rowand , linux-nvdimm , Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Jeff Dike , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman On Fri, Nov 30, 2018 at 08:05:34AM -0600, Rob Herring wrote: > On Thu, Nov 29, 2018 at 9:37 PM Luis Chamberlain wrote: > > > > On Wed, Nov 28, 2018 at 03:26:03PM -0600, Rob Herring wrote: > > > On Wed, Nov 28, 2018 at 1:37 PM Brendan Higgins > > > wrote: > > > > > > > > Make minimum number of changes outside of the KUnit directories for > > > > KUnit to build and run using UML. > > > > > > There's nothing in this patch limiting this to UML. > > > > Not that one, but the abort thing segv thing is, eventually. > > To support other architectures we'd need to make a wrapper to that > > hack which Brendan added, and then allow each os to implement > > its own call, and add an asm-generic helper. > > I've not looked into why this is needed, but can't you make the abort > support optional and arches can select it when they support it. Its why I have asked for it to be properly documented. The patches in no way illustrate *why* such thing is done. And if we are going to potentially have other archs do something similar best to make it explicit. > At > least before, the DT unittests didn't need this to run and shouldn't > depend on it after converting to kunit. Luis _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um