linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs
Date: Thu, 11 Apr 2019 11:49:44 +0200	[thread overview]
Message-ID: <20190411094944.12245-5-brgl@bgdev.pl> (raw)
In-Reply-To: <20190411094944.12245-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Setting a chip for an interrupt marks it as allocated. Since UM doesn't
support dynamic interrupt numbers (yet), it means we cannot simply
increase NR_IRQS and then use the free irqs between LAST_IRQ and NR_IRQS
with gpio-mockup or iio testing drivers as irq_alloc_descs() will fail
after not being able to neither find an unallocated range of interrupts
nor expand the range.

Only call irq_set_chip_and_handler() for irqs until LAST_IRQ.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
---
 arch/um/kernel/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c
index f4874b7ec503..598d7b3d9355 100644
--- a/arch/um/kernel/irq.c
+++ b/arch/um/kernel/irq.c
@@ -479,7 +479,7 @@ void __init init_IRQ(void)
 	irq_set_chip_and_handler(TIMER_IRQ, &SIGVTALRM_irq_type, handle_edge_irq);
 
 
-	for (i = 1; i < NR_IRQS; i++)
+	for (i = 1; i < LAST_IRQ; i++)
 		irq_set_chip_and_handler(i, &normal_irq_type, handle_edge_irq);
 	/* Initialize EPOLL Loop */
 	os_setup_epoll();
-- 
2.21.0



  parent reply	other threads:[~2019-04-11  9:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11  9:49 [RESEND PATCH 0/4] um: build and irq fixes Bartosz Golaszewski
2019-04-11  9:49 ` [RESEND PATCH 1/4] um: remove unused variable Bartosz Golaszewski
2019-04-11  9:49 ` [RESEND PATCH 2/4] um: remove uses of variable length arrays Bartosz Golaszewski
2019-04-11  9:49 ` [RESEND PATCH 3/4] um: define set_pte_at() as a static inline function, not a macro Bartosz Golaszewski
2019-04-11  9:49 ` Bartosz Golaszewski [this message]
2019-05-07 21:26   ` [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs Richard Weinberger
2019-05-08  7:09     ` Anton Ivanov
2019-05-08  7:13       ` Richard Weinberger
2019-05-10  9:16         ` Bartosz Golaszewski
2019-05-10 16:20           ` Bartosz Golaszewski
2019-05-10 16:22             ` Anton Ivanov
2019-05-11 12:48               ` Bartosz Golaszewski
2019-05-31 10:30                 ` Dana Johnson
2019-06-03  6:54                   ` Anton Ivanov
2019-06-03 19:32                     ` Dana Johnson
2019-04-14  7:57 ` [RESEND PATCH 0/4] um: build and irq fixes Richard Weinberger
  -- strict thread matches above, loose matches on Subject: below --
2019-04-03  8:38 Bartosz Golaszewski
2019-04-03  8:39 ` [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190411094944.12245-5-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=geert@linux-m68k.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).