From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQbuq-0005oc-HX for linux-um@lists.infradead.org; Tue, 14 May 2019 18:12:44 +0000 Received: by mail-pg1-x541.google.com with SMTP id 145so9013027pgg.9 for ; Tue, 14 May 2019 11:12:40 -0700 (PDT) Date: Tue, 14 May 2019 11:12:33 -0700 From: Brendan Higgins Subject: Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list Message-ID: <20190514181233.GB109557@google.com> References: <20190514054251.186196-1-brendanhiggins@google.com> <20190514054251.186196-9-brendanhiggins@google.com> <20190514065643.GC2589@hirez.programming.kicks-ass.net> <20190514081223.GA230665@google.com> <20190514084655.GK2589@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Peter Zijlstra Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com, dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, yamada.masahiro@socionext.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, shuah@kernel.org, robh@kernel.org, kbuild test robot , linux-nvdimm@lists.01.org, frowand.list@gmail.com, knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, Josh Poimboeuf , dan.j.williams@intel.com, kunit-dev@googlegroups.com, tytso@mit.edu, richard@nod.at, sboyd@kernel.org, gregkh@linuxfoundation.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch, keescook@google.com, linux-fsdevel@vger.kernel.org, logang@deltatee.com, khilman@baylibre.com On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote: > On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote: > > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote: > > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > > > > This fixes the following warning seen on GCC 7.3: > > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > > > > > > > > > What is that file and function; no kernel tree near me seems to have > > > that. > > > > Oh, sorry about that. The function is added in the following patch, > > "[PATCH v3 09/18] kunit: test: add support for test abort"[1]. > > > > My apologies if this patch is supposed to come after it in sequence, but > > I assumed it should come before otherwise objtool would complain about > > the symbol when it is introduced. > > Or send me all patches such that I have context, or have a sane > Changelog that gives me context. Just don't give me one patch with a > crappy changelog. I will provide more context in the next revision. Sorry about that! _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um