From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRQtb-0003vy-Ln for linux-um@lists.infradead.org; Fri, 17 May 2019 00:38:48 +0000 MIME-Version: 1.0 In-Reply-To: <20190514221711.248228-3-brendanhiggins@google.com> References: <20190514221711.248228-1-brendanhiggins@google.com> <20190514221711.248228-3-brendanhiggins@google.com> Subject: Re: [PATCH v4 02/18] kunit: test: add test resource management API From: Stephen Boyd Date: Thu, 16 May 2019 17:38:46 -0700 Message-Id: <20190517003847.0962F2082E@mail.kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins , frowand.list@gmail.com, gregkh@linuxfoundation.org, jpoimboe@redhat.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com, Brendan Higgins , dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, khilman@baylibre.com, knut.omang@oracle.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, kunit-dev@googlegroups.com, richard@nod.at, rdunlap@infradead.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, mpe@ellerman.id.au, linux-fsdevel@vger.kernel.org, logang@deltatee.com Quoting Brendan Higgins (2019-05-14 15:16:55) > diff --git a/kunit/test.c b/kunit/test.c > index 86f65ba2bcf92..a15e6f8c41582 100644 > --- a/kunit/test.c > +++ b/kunit/test.c [..] > + > +void *kunit_kmalloc(struct kunit *test, size_t size, gfp_t gfp) > +{ > + struct kunit_kmalloc_params params; > + struct kunit_resource *res; > + > + params.size = size; > + params.gfp = gfp; > + > + res = kunit_alloc_resource(test, > + kunit_kmalloc_init, > + kunit_kmalloc_free, > + ¶ms); > + > + if (res) > + return res->allocation; > + else > + return NULL; Can be written as if (res) return .... return and some static analysis tools prefer this. > +} > + > +void kunit_cleanup(struct kunit *test) > +{ > + struct kunit_resource *resource, *resource_safe; > + unsigned long flags; > + > + spin_lock_irqsave(&test->lock, flags); Ah ok, test->lock is protecting everything now? Does it need to be a spinlock, or can it be a mutex? > + list_for_each_entry_safe(resource, > + resource_safe, > + &test->resources, > + node) { > + kunit_free_resource(test, resource); > + } > + spin_unlock_irqrestore(&test->lock, flags); > +} > + _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um