From: Johannes Berg <johannes@sipsolutions.net>
To: linux-um@lists.infradead.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH 2/4] arch: um: avoid using uninitialized regs
Date: Fri, 23 Aug 2019 12:44:27 +0200 [thread overview]
Message-ID: <20190823104429.11047-2-johannes@sipsolutions.net> (raw)
In-Reply-To: <20190823104429.11047-1-johannes@sipsolutions.net>
From: Johannes Berg <johannes.berg@intel.com>
In timer_real_alarm_handler(), regs is only initialized if
the context argument is non-NULL, also initialize in the
other case.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
arch/um/os-Linux/signal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c
index 35d1b2bc00cb..4cd88b5b9006 100644
--- a/arch/um/os-Linux/signal.c
+++ b/arch/um/os-Linux/signal.c
@@ -10,6 +10,7 @@
#include <stdarg.h>
#include <errno.h>
#include <signal.h>
+#include <string.h>
#include <strings.h>
#include <as-layout.h>
#include <kern_util.h>
@@ -88,6 +89,8 @@ static void timer_real_alarm_handler(mcontext_t *mc)
if (mc != NULL)
get_regs_from_mc(®s, mc);
+ else
+ memset(®s, 0, sizeof(regs));
timer_handler(SIGALRM, NULL, ®s);
}
--
2.20.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2019-08-23 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 10:44 [PATCH 1/4] arch: um: remove sig_info[SIGALRM] Johannes Berg
2019-08-23 10:44 ` Johannes Berg [this message]
2019-08-27 5:28 ` [PATCH 2/4] arch: um: avoid using uninitialized regs Anton Ivanov
2019-08-23 10:44 ` [PATCH 3/4] arch: um: remove misleading #define ARCh_IRQ_ENABLED Johannes Berg
2019-08-27 5:28 ` Anton Ivanov
2019-08-23 10:44 ` [PATCH 4/4] arch: um: implement TRACE_IRQFLAGS_SUPPORT Johannes Berg
2019-08-27 5:27 ` [PATCH 1/4] arch: um: remove sig_info[SIGALRM] Anton Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823104429.11047-2-johannes@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=johannes.berg@intel.com \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox