From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihMzU-0004MX-1i for linux-um@lists.infradead.org; Wed, 18 Dec 2019 00:15:01 +0000 Received: by mail-pg1-x544.google.com with SMTP id 6so231755pgk.0 for ; Tue, 17 Dec 2019 16:14:59 -0800 (PST) Date: Tue, 17 Dec 2019 16:14:56 -0800 From: Kees Cook Subject: Re: [PATCH v1] lkdtm/bugs: fix build error in lkdtm_UNSET_SMEP Message-ID: <201912171613.454319D@keescook> References: <20191213003522.66450-1-brendanhiggins@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191213003522.66450-1-brendanhiggins@google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: arnd@arndb.de, richard@nod.at, jdike@addtoit.com, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, davidgow@google.com, gregkh@linuxfoundation.org, anton.ivanov@cambridgegreys.com T24gVGh1LCBEZWMgMTIsIDIwMTkgYXQgMDQ6MzU6MjJQTSAtMDgwMCwgQnJlbmRhbiBIaWdnaW5z IHdyb3RlOgo+IFdoZW4gYnVpbGRpbmcgQVJDSD11bSB3aXRoIENPTkZJR19VTUxfWDg2PXkgYW5k IENPTkZJR182NEJJVD15IHdlIGdldAo+IHRoZSBidWlsZCBlcnJvcnM6Cj4gCj4gZHJpdmVycy9t aXNjL2xrZHRtL2J1Z3MuYzogSW4gZnVuY3Rpb24g4oCYbGtkdG1fVU5TRVRfU01FUOKAmToKPiBk cml2ZXJzL21pc2MvbGtkdG0vYnVncy5jOjI4ODo4OiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRp b24gb2YgZnVuY3Rpb24g4oCYbmF0aXZlX3JlYWRfY3I04oCZIFstV2Vycm9yPWltcGxpY2l0LWZ1 bmN0aW9uLWRlY2xhcmF0aW9uXQo+ICAgY3I0ID0gbmF0aXZlX3JlYWRfY3I0KCk7Cj4gICAgICAg ICBefn5+fn5+fn5+fn5+fn4KPiBkcml2ZXJzL21pc2MvbGtkdG0vYnVncy5jOjI5MDoxMzogZXJy b3I6IOKAmFg4Nl9DUjRfU01FUOKAmSB1bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4gdGhpcyBmdW5j dGlvbik7IGRpZCB5b3UgbWVhbiDigJhYODZfRkVBVFVSRV9TTUVQ4oCZPwo+ICAgaWYgKChjcjQg JiBYODZfQ1I0X1NNRVApICE9IFg4Nl9DUjRfU01FUCkgewo+ICAgICAgICAgICAgICBefn5+fn5+ fn5+fn4KPiAgICAgICAgICAgICAgWDg2X0ZFQVRVUkVfU01FUAo+IGRyaXZlcnMvbWlzYy9sa2R0 bS9idWdzLmM6MjkwOjEzOiBub3RlOiBlYWNoIHVuZGVjbGFyZWQgaWRlbnRpZmllciBpcyByZXBv cnRlZCBvbmx5IG9uY2UgZm9yIGVhY2ggZnVuY3Rpb24gaXQgYXBwZWFycyBpbgo+IGRyaXZlcnMv bWlzYy9sa2R0bS9idWdzLmM6Mjk3OjI6IGVycm9yOiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBvZiBm dW5jdGlvbiDigJhuYXRpdmVfd3JpdGVfY3I04oCZOyBkaWQgeW91IG1lYW4g4oCYZGlyZWN0X3dy aXRlX2NyNOKAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gICBu YXRpdmVfd3JpdGVfY3I0KGNyNCk7Cj4gICBefn5+fn5+fn5+fn5+fn5+Cj4gICBkaXJlY3Rfd3Jp dGVfY3I0Cj4gCj4gU28gc3BlY2lmeSB0aGF0IHRoaXMgYmxvY2sgb2YgY29kZSBzaG91bGQgb25s eSBidWlsZCB3aGVuCj4gQ09ORklHX1g4Nl82ND15ICpBTkQqIENPTkZJR19VTUwgaXMgdW5zZXQu Cj4gCj4gU2lnbmVkLW9mZi1ieTogQnJlbmRhbiBIaWdnaW5zIDxicmVuZGFuaGlnZ2luc0Bnb29n bGUuY29tPgoKVGhhbmtzIGZvciBjYXRjaGluZyB0aGlzISBJcyBhIHNpbWlsYXIgbWFya2luZyBu ZWVkZWQgZm9yIHRoZSByZWNlbnRseQphZGRlZCBsa2R0bV9ET1VCTEVfRkFVTFQoKSB3aGVuIHVz aW5nIFVNTCBvbiAzMi1iaXQ/CgpBY2tlZC1ieTogS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1 bS5vcmc+CgotS2VlcwoKPiAtLS0KPiAKPiBUaGlzIHBhdGNoIGlzIHBhcnQgb2YgbXkgbGFyZ2Vy IGVmZm9ydCB0byBnZXQgYWxseWVzY29uZmlnIGNsb3NlciB0bwo+IHdvcmtpbmcgZm9yIEFSQ0g9 dW0uIEZvciBtb3JlIGluZm9ybWF0aW9uIGFib3V0IHRoYXQsIGNoZWNrb3V0IHRoZSBjb3Zlcgo+ IGxldHRlciBmb3IgYSByZWxhdGVkIHBhdGNoc2V0IGhlcmU6Cj4gCj4gaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvbGttbC8yMDE5MTIxMTE5Mjc0Mi45NTY5OS0xLWJyZW5kYW5oaWdnaW5zQGdvb2ds ZS5jb20vCj4gCj4gLS0tCj4gIGRyaXZlcnMvbWlzYy9sa2R0bS9idWdzLmMgfCAyICstCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL21pc2MvbGtkdG0vYnVncy5jIGIvZHJpdmVycy9taXNjL2xrZHRtL2J1Z3Mu Ywo+IGluZGV4IGE0ZmRhZDA0ODA5YTkuLjZjMWFhYjE3N2ZjZWQgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9taXNjL2xrZHRtL2J1Z3MuYwo+ICsrKyBiL2RyaXZlcnMvbWlzYy9sa2R0bS9idWdzLmMK PiBAQCAtMjc4LDcgKzI3OCw3IEBAIHZvaWQgbGtkdG1fU1RBQ0tfR1VBUkRfUEFHRV9UUkFJTElO Ryh2b2lkKQo+ICAKPiAgdm9pZCBsa2R0bV9VTlNFVF9TTUVQKHZvaWQpCj4gIHsKPiAtI2lmZGVm IENPTkZJR19YODZfNjQKPiArI2lmIElTX0VOQUJMRUQoQ09ORklHX1g4Nl82NCkgJiYgIUlTX0VO QUJMRUQoQ09ORklHX1VNTCkKPiAgI2RlZmluZSBNT1ZfQ1I0X0RFUFRICTY0Cj4gIAl2b2lkICgq ZGlyZWN0X3dyaXRlX2NyNCkodW5zaWduZWQgbG9uZyB2YWwpOwo+ICAJdW5zaWduZWQgY2hhciAq aW5zbjsKPiAtLSAKPiAyLjI0LjEuNzM1LmcwM2Y0ZTcyODE3LWdvb2cKPiAKCi0tIApLZWVzIENv b2sKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LXVtIG1haWxpbmcgbGlzdApsaW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0K