From: Leon Romanovsky <leon@kernel.org>
To: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Leon Romanovsky <leonro@mellanox.com>,
linux-um <linux-um@lists.infradead.org>
Subject: [PATCH 1/2] um: Don't overwrite ethtool driver version
Date: Thu, 20 Feb 2020 10:40:13 +0200 [thread overview]
Message-ID: <20200220084014.238768-2-leon@kernel.org> (raw)
In-Reply-To: <20200220084014.238768-1-leon@kernel.org>
From: Leon Romanovsky <leonro@mellanox.com>
In-tree drivers don't need to manage internal version because
they are aligned to the global Linux kernel version, which is
reported by default with "ethtool -i".
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
arch/um/drivers/net_kern.c | 1 -
arch/um/drivers/vector_kern.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 35ebeebfc1a8..af07733c2dc8 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -266,7 +266,6 @@ static void uml_net_get_drvinfo(struct net_device *dev,
struct ethtool_drvinfo *info)
{
strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver));
- strlcpy(info->version, "42", sizeof(info->version));
}
static const struct ethtool_ops uml_net_ethtool_ops = {
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index 0ff86391f77d..9693dfca7651 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -46,7 +46,6 @@
#define DRIVER_NAME "uml-vector"
-#define DRIVER_VERSION "01"
struct vector_cmd_line_arg {
struct list_head list;
int unit;
@@ -1378,7 +1377,6 @@ static void vector_net_get_drvinfo(struct net_device *dev,
struct ethtool_drvinfo *info)
{
strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver));
- strlcpy(info->version, DRIVER_VERSION, sizeof(info->version));
}
static int vector_net_load_bpf_flash(struct net_device *dev,
--
2.24.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-02-20 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:40 [PATCH 0/2] Remove dead code and driver version Leon Romanovsky
2020-02-20 8:40 ` Leon Romanovsky [this message]
2020-02-20 19:35 ` [PATCH 1/2] um: Don't overwrite ethtool " Anton Ivanov
2020-03-29 21:38 ` Richard Weinberger
2020-03-30 7:22 ` Leon Romanovsky
2020-02-20 8:40 ` [PATCH 2/2] um: Delete never executed timer Leon Romanovsky
2020-02-20 19:36 ` Anton Ivanov
2020-02-20 19:35 ` [PATCH 0/2] Remove dead code and driver version Anton Ivanov
2020-02-23 10:51 ` Leon Romanovsky
2020-02-23 19:58 ` Anton Ivanov
2020-02-24 16:45 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220084014.238768-2-leon@kernel.org \
--to=leon@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=jdike@addtoit.com \
--cc=leonro@mellanox.com \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).