From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYxEc-0003KO-OM for linux-um@lists.infradead.org; Wed, 13 May 2020 19:40:08 +0000 Date: Wed, 13 May 2020 21:40:03 +0200 From: Christoph Hellwig Subject: Re: [PATCH 14/18] maccess: allow architectures to provide kernel probing directly Message-ID: <20200513194003.GA31028@lst.de> References: <20200513160038.2482415-1-hch@lst.de> <20200513160038.2482415-15-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Linus Torvalds Cc: linux-parisc@vger.kernel.org, Daniel Borkmann , Netdev , the arch/x86 maintainers , linux-um , Alexei Starovoitov , Linux Kernel Mailing List , Linux-MM , bpf@vger.kernel.org, Masami Hiramatsu , Andrew Morton , Christoph Hellwig On Wed, May 13, 2020 at 12:36:18PM -0700, Linus Torvalds wrote: > > + arch_kernel_read(dst, src, type, err_label); \ > > I'm wondering if > > (a) we shouldn't expose this as an interface in general We do export something like it, currently it is called probe_kernel_address, and the last patch renames it to get_kernel_nofault. However it is implemented as a wrapper around probe_kernel_address / copy_from_kernel_nofault and thus not quite as efficient and without the magic goto semantics. > (b) it wouldn't be named differently.. It probably should with all the renaming.. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um