From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
linux-um@lists.infradead.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] rtc: enable RTC framework on ARCH=um
Date: Fri, 20 Nov 2020 23:39:14 +0100 [thread overview]
Message-ID: <20201120223914.GD348979@piout.net> (raw)
In-Reply-To: <20201120211103.6895ac740d11.Ic19a9926e8e4c70c03329e55f9e5b1d45095b904@changeid>
On 20/11/2020 21:11:06+0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There's no real reason it should be disabled, and at least we can
> use it for development & testing with the RTC test driver.
>
> However, two devices are missing a HAS_IOMEM dependency, so add
> that to avoid build failures from e.g. allyesconfig.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Would there be objection to taking this through the linux-um tree?
> I have a couple of patches that depend on it as well, to add
> suspend/resume support with a pseudo-RTC to wake up from it.
I'm fine with that.
> ---
> drivers/rtc/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 48c536acd777..de187b563989 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -13,7 +13,7 @@ config RTC_MC146818_LIB
> menuconfig RTC_CLASS
> bool "Real Time Clock"
> default n
> - depends on !S390 && !UML
> + depends on !S390
> select RTC_LIB
> help
> Generic RTC class support. If you say yes here, you will
> @@ -1007,6 +1007,7 @@ config RTC_DRV_DS1553
>
> config RTC_DRV_DS1685_FAMILY
> tristate "Dallas/Maxim DS1685 Family"
> + depends on HAS_IOMEM
> help
> If you say yes here you get support for the Dallas/Maxim DS1685
> family of real time chips. This family includes the DS1685/DS1687,
> @@ -1140,6 +1141,7 @@ config RTC_DRV_STK17TA8
>
> config RTC_DRV_M48T86
> tristate "ST M48T86/Dallas DS12887"
> + depends on HAS_IOMEM
> help
> If you say Y here you will get support for the
> ST M48T86 and Dallas DS12887 RTC chips.
> --
> 2.26.2
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-11-20 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 20:11 [PATCH] rtc: enable RTC framework on ARCH=um Johannes Berg
2020-11-20 22:39 ` Alexandre Belloni [this message]
2020-11-21 9:51 ` Johannes Berg
2020-12-03 22:41 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120223914.GD348979@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox