From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 22 Jul 2021 15:02:09 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user Message-ID: <20210722130209.GG26225@lst.de> References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-8-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722124814.778059-8-arnd@kernel.org> To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori Sato , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp, Geert Uytterhoeven List-ID: On Thu, Jul 22, 2021 at 02:48:12PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The inline version is used on three NOMMU architectures and is > particularly inefficient when it scans the string one byte at a time > twice. It also lacks a check for user_addr_max(), but this is > probably ok on NOMMU targets. > > Consolidate the asm-generic implementation with the library version > that is used everywhere else. This version is generalized enough to > work efficiently on both MMU and NOMMU targets, and using the > same code everywhere reduces the potential for subtle bugs. > > Reviewed-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven > Signed-off-by: Arnd Bergmann Looks good, Reviewed-by: Christoph Hellwig