From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNOr5-002orW-QI for linux-um@lists.infradead.org; Fri, 25 Feb 2022 00:53:09 +0000 MIME-Version: 1.0 In-Reply-To: <20220224035902.1594253-1-davidgow@google.com> References: <20220224035902.1594253-1-davidgow@google.com> Subject: Re: [PATCH] clk: lan966x: Depend on CONFIG_IOMEM From: Stephen Boyd Date: Thu, 24 Feb 2022 16:53:02 -0800 Message-Id: <20220225005304.140FFC340E9@smtp.kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: David Gow , Michael Turquette Cc: David Gow , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-um@lists.infradead.org Quoting David Gow (2022-02-23 19:59:02) > The lan966x clk driver depends on IOMEM functions, in particular > devm_platform_ioremap_resource(), but doesn't state a formal dependency > on it in Kconfig. > > Add such a dependency, which prevents this driver from being enabled > on UML configurations without IOMEM. > > This fixes the following build failure: > > /usr/bin/ld: drivers/clk/clk-lan966x.o: in function `lan966x_clk_probe': > clk-lan966x.c:(.text+0x294): undefined reference to `devm_platform_ioremap_resource' > /usr/bin/ld: clk-lan966x.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource' > collect2: error: ld returned 1 exit status > > Signed-off-by: David Gow > --- > drivers/clk/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 3cdf33470a75..7b5db8a9eb4f 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -231,6 +231,7 @@ config COMMON_CLK_GEMINI > > config COMMON_CLK_LAN966X > bool "Generic Clock Controller driver for LAN966X SoC" > + depends on IOMEM What is CONFIG_IOMEM? This is superseded by https://lore.kernel.org/r/20220219141536.460812-1-horatiu.vultur@microchip.com > help > This driver provides support for Generic Clock Controller(GCK) on > LAN966X SoC. GCK generates and supplies clock to various peripherals _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um