From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntWRw-008RbH-OQ for linux-um@lists.infradead.org; Tue, 24 May 2022 15:27:58 +0000 Date: Tue, 24 May 2022 17:27:25 +0200 From: Oleg Nesterov Subject: Re: [PATCH 08/16] ptrace: Only populate last_siginfo from ptrace Message-ID: <20220524152725.GE14347@redhat.com> References: <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> <20220518225355.784371-8-ebiederm@xmission.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220518225355.784371-8-ebiederm@xmission.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, bigeasy@linutronix.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn , linux-ia64@vger.kernel.org, Robert OCallahan , Kyle Huey , Richard Henderson , Ivan Kokshaysky , Matt Turner , Jason Wessel , Daniel Thompson , Douglas Anderson , Douglas Miller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras On 05/18, Eric W. Biederman wrote: > > The code in ptrace_signal to populate siginfo if the signal number > changed is buggy. If the tracer contined the tracee using > ptrace_detach it is guaranteed to use the real_parent (or possibly a > new tracer) but definitely not the origional tracer to populate si_pid > and si_uid. I guess nobody cares. As the comment says If the debugger wanted something specific in the siginfo structure then it should have updated *info via PTRACE_SETSIGINFO. otherwise I don't think si_pid/si_uid have any value. However the patch looks fine to me, just the word "buggy" looks a bit too strong imo. Oleg. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um