From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFBD5C7EE25 for ; Wed, 7 Jun 2023 12:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wvY6zJ7GtwUEwk+Up7FmRCuyeYn8lZ6+obpAW6J4yuo=; b=AEHkYupT1Td8Z1 ZuqgSEjlwfXbXr4Fq+XsbD8IhxcQV0i5hEmGtSDkBJ0Mji51ACpatIl7srHDw74XgjpyZyWtJkrWQ zVHms8g2AwKivS0mzRUdH1Ywtdoy1HdT7h2PAF/D5y4d1tyxQGfk6EzvkMQYRxclUPFUXBCgxjB5O +JlBXV6BVRVuUJLZLdFT7kt15F74AqYEdb+EjD/HeCwAs3NseqGFJMpR0kwnLLlPEM1D5k4OBDNjV wChO0CsCrlLtDE9JIQzK3MxE/+Rg3cPesyaCSb/v30AaK5h3rIkF+sx93IGQoVHIBhhdKTS8hgm8p JO5eT5b0Un0CuSpQ2d0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6s9h-005qWU-14; Wed, 07 Jun 2023 12:20:49 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6s9d-005qUX-16; Wed, 07 Jun 2023 12:20:47 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id C229F6732D; Wed, 7 Jun 2023 14:20:41 +0200 (CEST) Date: Wed, 7 Jun 2023 14:20:41 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data Message-ID: <20230607122041.GA14579@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-6-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_052045_522238_A9C8A601 X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 02:13:33PM +0200, Hannes Reinecke wrote: >> +++ b/include/linux/cdrom.h >> @@ -64,6 +64,7 @@ struct cdrom_device_info { >> int (*exit)(struct cdrom_device_info *); >> int mrw_mode_page; >> __s64 last_media_change_ms; >> + bool opened_for_data; >> }; >> struct cdrom_device_ops { > > Do we care about alignment here? > integer followed by a 64 bit value followed by a bool seems > like an automatic padding to me ... I don't think the structure matter much here, but placing it before last_media_change_ms still seems better. I'll change it. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um