From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, Hugh Dickins <hughd@google.com>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
Huacai Chen <chenhuacai@kernel.org>,
Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v5 23/33] loongarch: Convert various functions to use ptdescs
Date: Thu, 22 Jun 2023 13:57:35 -0700 [thread overview]
Message-ID: <20230622205745.79707-24-vishal.moola@gmail.com> (raw)
In-Reply-To: <20230622205745.79707-1-vishal.moola@gmail.com>
As part of the conversions to replace pgtable constructor/destructors with
ptdesc equivalents, convert various page table functions to use ptdescs.
Some of the functions use the *get*page*() helper functions. Convert
these to use pagetable_alloc() and ptdesc_address() instead to help
standardize page tables further.
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
---
arch/loongarch/include/asm/pgalloc.h | 27 +++++++++++++++------------
arch/loongarch/mm/pgtable.c | 7 ++++---
2 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h
index af1d1e4a6965..23f5b1107246 100644
--- a/arch/loongarch/include/asm/pgalloc.h
+++ b/arch/loongarch/include/asm/pgalloc.h
@@ -45,9 +45,9 @@ extern void pagetable_init(void);
extern pgd_t *pgd_alloc(struct mm_struct *mm);
#define __pte_free_tlb(tlb, pte, address) \
-do { \
- pgtable_pte_page_dtor(pte); \
- tlb_remove_page((tlb), pte); \
+do { \
+ pagetable_pte_dtor(page_ptdesc(pte)); \
+ tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \
} while (0)
#ifndef __PAGETABLE_PMD_FOLDED
@@ -55,18 +55,18 @@ do { \
static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
{
pmd_t *pmd;
- struct page *pg;
+ struct ptdesc *ptdesc;
- pg = alloc_page(GFP_KERNEL_ACCOUNT);
- if (!pg)
+ ptdesc = pagetable_alloc(GFP_KERNEL_ACCOUNT, 0);
+ if (!ptdesc)
return NULL;
- if (!pgtable_pmd_page_ctor(pg)) {
- __free_page(pg);
+ if (!pagetable_pmd_ctor(ptdesc)) {
+ pagetable_free(ptdesc);
return NULL;
}
- pmd = (pmd_t *)page_address(pg);
+ pmd = ptdesc_address(ptdesc);
pmd_init(pmd);
return pmd;
}
@@ -80,10 +80,13 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
{
pud_t *pud;
+ struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0);
- pud = (pud_t *) __get_free_page(GFP_KERNEL);
- if (pud)
- pud_init(pud);
+ if (!ptdesc)
+ return NULL;
+ pud = ptdesc_address(ptdesc);
+
+ pud_init(pud);
return pud;
}
diff --git a/arch/loongarch/mm/pgtable.c b/arch/loongarch/mm/pgtable.c
index 36a6dc0148ae..5bd102b51f7c 100644
--- a/arch/loongarch/mm/pgtable.c
+++ b/arch/loongarch/mm/pgtable.c
@@ -11,10 +11,11 @@
pgd_t *pgd_alloc(struct mm_struct *mm)
{
- pgd_t *ret, *init;
+ pgd_t *init, *ret = NULL;
+ struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0);
- ret = (pgd_t *) __get_free_page(GFP_KERNEL);
- if (ret) {
+ if (ptdesc) {
+ ret = (pgd_t *)ptdesc_address(ptdesc);
init = pgd_offset(&init_mm, 0UL);
pgd_init(ret);
memcpy(ret + USER_PTRS_PER_PGD, init + USER_PTRS_PER_PGD,
--
2.40.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-06-22 21:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 20:57 [PATCH v5 00/33] Split ptdesc from struct page Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 01/33] mm: Add PAGE_TYPE_OP folio functions Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 02/33] s390: Use _pt_s390_gaddr for gmap address tracking Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 03/33] pgtable: Create struct ptdesc Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 04/33] mm: add utility functions for ptdesc Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 05/33] mm: Convert pmd_pgtable_page() to pmd_ptdesc() Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 06/33] mm: Convert ptlock_alloc() to use ptdescs Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 07/33] mm: Convert ptlock_ptr() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 08/33] mm: Convert pmd_ptlock_init() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 09/33] mm: Convert ptlock_init() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 10/33] mm: Convert pmd_ptlock_free() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 11/33] mm: Convert ptlock_free() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 12/33] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 13/33] powerpc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 14/33] x86: " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 15/33] s390: Convert various gmap " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 16/33] s390: Convert various pgalloc " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 17/33] mm: Remove page table members from struct page Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 18/33] pgalloc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 19/33] arm: " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 20/33] arm64: " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 21/33] csky: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 22/33] hexagon: " Vishal Moola (Oracle)
2023-06-22 20:57 ` Vishal Moola (Oracle) [this message]
2023-06-22 20:57 ` [PATCH v5 24/33] m68k: Convert various functions " Vishal Moola (Oracle)
2023-06-25 7:57 ` kernel test robot
2023-06-25 8:51 ` Geert Uytterhoeven
2023-06-22 20:57 ` [PATCH v5 25/33] mips: " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 26/33] nios2: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-06-22 22:05 ` Dinh Nguyen
2023-06-27 5:47 ` Guenter Roeck
2023-06-27 17:42 ` Vishal Moola
2023-06-27 19:10 ` Guenter Roeck
2023-06-27 19:14 ` Guenter Roeck
2023-06-27 19:56 ` Vishal Moola
2023-06-27 20:05 ` Dinh Nguyen
2023-06-27 21:01 ` Guenter Roeck
2023-06-27 21:46 ` Dinh Nguyen
2023-06-27 21:57 ` Guenter Roeck
2023-06-22 20:57 ` [PATCH v5 27/33] openrisc: " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 28/33] riscv: Convert alloc_{pmd, pte}_late() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 29/33] sh: Convert pte_free_tlb() " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 30/33] sparc64: Convert various functions " Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 31/33] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 32/33] um: Convert {pmd, pte}_free_tlb() to use ptdescs Vishal Moola (Oracle)
2023-06-22 20:57 ` [PATCH v5 33/33] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Vishal Moola (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622205745.79707-24-vishal.moola@gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@kernel.org \
--cc=hughd@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).