From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, xen-devel@lists.xenproject.org,
kvm@vger.kernel.org, Hugh Dickins <hughd@google.com>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Subject: [PATCH v6 04/33] mm: add utility functions for ptdesc
Date: Mon, 26 Jun 2023 20:14:02 -0700 [thread overview]
Message-ID: <20230627031431.29653-5-vishal.moola@gmail.com> (raw)
In-Reply-To: <20230627031431.29653-1-vishal.moola@gmail.com>
Introduce utility functions setting the foundation for ptdescs. These
will also assist in the splitting out of ptdesc from struct page.
Functions that focus on the descriptor are prefixed with ptdesc_* while
functions that focus on the pagetable are prefixed with pagetable_*.
pagetable_alloc() is defined to allocate new ptdesc pages as compound
pages. This is to standardize ptdescs by allowing for one allocation
and one free function, in contrast to 2 allocation and 2 free functions.
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
---
include/asm-generic/tlb.h | 11 ++++++++
include/linux/mm.h | 56 +++++++++++++++++++++++++++++++++++++++
include/linux/pgtable.h | 12 +++++++++
3 files changed, 79 insertions(+)
diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
index b46617207c93..6bade9e0e799 100644
--- a/include/asm-generic/tlb.h
+++ b/include/asm-generic/tlb.h
@@ -481,6 +481,17 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page)
return tlb_remove_page_size(tlb, page, PAGE_SIZE);
}
+static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt)
+{
+ tlb_remove_table(tlb, pt);
+}
+
+/* Like tlb_remove_ptdesc, but for page-like page directories. */
+static inline void tlb_remove_page_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt)
+{
+ tlb_remove_page(tlb, ptdesc_page(pt));
+}
+
static inline void tlb_change_page_size(struct mmu_gather *tlb,
unsigned int page_size)
{
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 0dad5f40ef96..14d95d494958 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2744,6 +2744,57 @@ static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long a
}
#endif /* CONFIG_MMU */
+static inline struct ptdesc *virt_to_ptdesc(const void *x)
+{
+ return page_ptdesc(virt_to_page(x));
+}
+
+static inline void *ptdesc_to_virt(const struct ptdesc *pt)
+{
+ return page_to_virt(ptdesc_page(pt));
+}
+
+static inline void *ptdesc_address(const struct ptdesc *pt)
+{
+ return folio_address(ptdesc_folio(pt));
+}
+
+static inline bool pagetable_is_reserved(struct ptdesc *pt)
+{
+ return folio_test_reserved(ptdesc_folio(pt));
+}
+
+/**
+ * pagetable_alloc - Allocate pagetables
+ * @gfp: GFP flags
+ * @order: desired pagetable order
+ *
+ * pagetable_alloc allocates memory for page tables as well as a page table
+ * descriptor to describe that memory.
+ *
+ * Return: The ptdesc describing the allocated page tables.
+ */
+static inline struct ptdesc *pagetable_alloc(gfp_t gfp, unsigned int order)
+{
+ struct page *page = alloc_pages(gfp | __GFP_COMP, order);
+
+ return page_ptdesc(page);
+}
+
+/**
+ * pagetable_free - Free pagetables
+ * @pt: The page table descriptor
+ *
+ * pagetable_free frees the memory of all page tables described by a page
+ * table descriptor and the memory for the descriptor itself.
+ */
+static inline void pagetable_free(struct ptdesc *pt)
+{
+ struct page *page = ptdesc_page(pt);
+
+ __free_pages(page, compound_order(page));
+}
+
#if USE_SPLIT_PTE_PTLOCKS
#if ALLOC_SPLIT_PTLOCKS
void __init ptlock_cache_init(void);
@@ -2981,6 +3032,11 @@ static inline void mark_page_reserved(struct page *page)
adjust_managed_page_count(page, -1);
}
+static inline void free_reserved_ptdesc(struct ptdesc *pt)
+{
+ free_reserved_page(ptdesc_page(pt));
+}
+
/*
* Default method to free all the __init memory into the buddy system.
* The freed pages will be poisoned with pattern "poison" if it's within
diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
index d46cb709ce08..e9bb5f18cade 100644
--- a/include/linux/pgtable.h
+++ b/include/linux/pgtable.h
@@ -1055,6 +1055,18 @@ TABLE_MATCH(memcg_data, pt_memcg_data);
#undef TABLE_MATCH
static_assert(sizeof(struct ptdesc) <= sizeof(struct page));
+#define ptdesc_page(pt) (_Generic((pt), \
+ const struct ptdesc *: (const struct page *)(pt), \
+ struct ptdesc *: (struct page *)(pt)))
+
+#define ptdesc_folio(pt) (_Generic((pt), \
+ const struct ptdesc *: (const struct folio *)(pt), \
+ struct ptdesc *: (struct folio *)(pt)))
+
+#define page_ptdesc(p) (_Generic((p), \
+ const struct page *: (const struct ptdesc *)(p), \
+ struct page *: (struct ptdesc *)(p)))
+
/*
* No-op macros that just return the current protection value. Defined here
* because these macros can be used even if CONFIG_MMU is not defined.
--
2.40.1
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-06-27 3:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 3:13 [PATCH v6 00/33] Split ptdesc from struct page Vishal Moola (Oracle)
2023-06-27 3:13 ` [PATCH v6 01/33] mm: Add PAGE_TYPE_OP folio functions Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 02/33] s390: Use _pt_s390_gaddr for gmap address tracking Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 03/33] pgtable: Create struct ptdesc Vishal Moola (Oracle)
2023-06-27 16:07 ` Peter Xu
2023-06-27 17:51 ` Vishal Moola
2023-06-27 3:14 ` Vishal Moola (Oracle) [this message]
2023-06-27 3:14 ` [PATCH v6 05/33] mm: Convert pmd_pgtable_page() to pmd_ptdesc() Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 06/33] mm: Convert ptlock_alloc() to use ptdescs Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 07/33] mm: Convert ptlock_ptr() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 08/33] mm: Convert pmd_ptlock_init() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 09/33] mm: Convert ptlock_init() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 10/33] mm: Convert pmd_ptlock_free() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 11/33] mm: Convert ptlock_free() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 12/33] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 13/33] powerpc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 14/33] x86: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 15/33] s390: Convert various gmap " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 16/33] s390: Convert various pgalloc " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 17/33] mm: Remove page table members from struct page Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 18/33] pgalloc: Convert various functions to use ptdescs Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 19/33] arm: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 20/33] arm64: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 21/33] csky: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 22/33] hexagon: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 23/33] loongarch: Convert various functions " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 24/33] m68k: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 25/33] mips: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 26/33] nios2: Convert __pte_free_tlb() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 27/33] openrisc: " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 28/33] riscv: Convert alloc_{pmd, pte}_late() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 29/33] sh: Convert pte_free_tlb() " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 30/33] sparc64: Convert various functions " Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 31/33] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 32/33] um: Convert {pmd, pte}_free_tlb() to use ptdescs Vishal Moola (Oracle)
2023-06-27 3:14 ` [PATCH v6 33/33] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Vishal Moola (Oracle)
2023-06-27 4:44 ` [PATCH v6 00/33] Split ptdesc from struct page Hugh Dickins
2023-06-27 7:14 ` David Hildenbrand
2023-06-27 20:13 ` Hugh Dickins
2023-06-28 7:41 ` David Hildenbrand
2023-06-28 18:51 ` Matthew Wilcox
2023-06-27 15:57 ` Matthew Wilcox
2023-06-27 20:25 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627031431.29653-5-vishal.moola@gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).