From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB973C54E5D for ; Tue, 19 Mar 2024 07:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=foUSQQGmYmOu8nLXi1AjlC9r9SGWzmdXWf6sigKcUWw=; b=Iqz02F/2Oa2/Tf9VUknD9xqBS5 LwvuDGZgSgKccEa+QUxt77+z6j84Q4GBiBGaKXWYPOccAJ7ui9tMoZEum/otHGAVBkIqZRFSlXtU8 2lDczjV9AwuI9yz/WlTkhddtZftpXUK1Dmh8spIhn/L/fYO/7G+h5Su8VPQKwGfiuZsKy0EI3Ec2J 2ClqTpO4dPK1B0WVK5yb9i8he7eizG+wxSeHmf9b8JPAPfuzlshj+YW5hNoVm/kPXcKzWKVYh6+uX fphlHzzSWhPISv7xQbhLvClg4HVFtH6r+RNotKnuc6ICJ5Os55+L3S6XmDTAEB/pKm1YIH6bwV2na RFctaXpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTTL-0000000BbhO-0vV5; Tue, 19 Mar 2024 07:01:19 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmTTI-0000000Bbgq-02RN for linux-um@lists.infradead.org; Tue, 19 Mar 2024 07:01:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710831674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=foUSQQGmYmOu8nLXi1AjlC9r9SGWzmdXWf6sigKcUWw=; b=Zal7cuN10qazRbahZtmjEkWoeQv69CBEEZpTNm7ZoHh9ssATscXqs2AlwQ5qxgY+cLLfro k9q19wx/txFI0c5LBcFfqGZrgmHhd1K9XKAX8O8ce+QGLY+mJmjku1rKWAXUU9p2ju5cKK Vwsl5zfK1UcEtGShXoh1i2z1oUi64+w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-mM_o6ERNN56oWK5ebkWDHA-1; Tue, 19 Mar 2024 03:01:10 -0400 X-MC-Unique: mM_o6ERNN56oWK5ebkWDHA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4140a509ee9so12063485e9.3 for ; Tue, 19 Mar 2024 00:01:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710831669; x=1711436469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=foUSQQGmYmOu8nLXi1AjlC9r9SGWzmdXWf6sigKcUWw=; b=FeBg6oyUO1e775gLX5Bo0UpDg7U2QYarr1qr00ga3u8H6VqiCDwVpWslF+xAgN8kEN ozp797zh+ivzzb2SRSu6pccL8aLL3q1qdh9/9wkphTz5ceTPFQk+998GNuR0RlSrWwxT Bt+4a5I/NpNpOkyZOvYIoFcftL/rmlh4sZvzVePXQh63okhOR2bS+F/xlzXhyCPCXjdO WbgsSNZqI45Va3khRyAQFCQ8TTqcDdqklUkbYoFfNl3CKHG0UoXeblZmVwJN1Rgx2909 BcfCQb1DBEm8gkvNmm1I69nUvoLGKNKlOYDFrafqjb/J6VWK1uQV+Wror8l88F2bFLMw oHbw== X-Forwarded-Encrypted: i=1; AJvYcCVXARRYijksPWgfQiUnfrIillZ/tNKmr+okBfs+hwVohBZDntDYGOo9sQKDyrJ9Ex5Qq3k9tq/QE1SJMMAyYcbTTFtfYc/QfnsqbsVE X-Gm-Message-State: AOJu0YzfF81nKR904FCwvzj0flFupeOZKFOFw/vTKJbmfqZMFoV/YZEU HfYwJG+T7SJZlV7/Tqsrta67Axi3rZ16J1QI0dPdH1Zf04Rd2Ft7sry3mrEHZbKKfy2XHCmQWQC 4eXJjbFFYQwRz0ymPUJXJF/YFPTnN9If8zyFkOVLGl5LqZ33NuQK3WavV7lE9Uw== X-Received: by 2002:a05:600c:4f0e:b0:413:ef8e:4cc with SMTP id l14-20020a05600c4f0e00b00413ef8e04ccmr1095497wmq.40.1710831669521; Tue, 19 Mar 2024 00:01:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzg6YzD09DcsuSp1mTE4kCrxMGUWI9Lm91o60NEdPSVsYEnPJ0jVjqFhsmb8yxRUdsUTgvyQ== X-Received: by 2002:a05:600c:4f0e:b0:413:ef8e:4cc with SMTP id l14-20020a05600c4f0e00b00413ef8e04ccmr1095470wmq.40.1710831668946; Tue, 19 Mar 2024 00:01:08 -0700 (PDT) Received: from redhat.com ([2.52.6.254]) by smtp.gmail.com with ESMTPSA id fk10-20020a05600c0cca00b0041463334822sm1536373wmb.26.2024.03.19.00.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 00:01:08 -0700 (PDT) Date: Tue, 19 Mar 2024 03:01:02 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: virtualization@lists.linux.dev, Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Jason Wang , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH vhost v3 0/4] refactor the params of find_vqs() Message-ID: <20240319025933-mutt-send-email-mst@kernel.org> References: <20240312021013.88656-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <20240312021013.88656-1-xuanzhuo@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_000116_277348_CC25E521 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Tue, Mar 12, 2024 at 10:10:09AM +0800, Xuan Zhuo wrote: > This pathset is splited from the > > http://lore.kernel.org/all/20240229072044.77388-1-xuanzhuo@linux.alibaba.com > > That may needs some cycles to discuss. But that notifies too many people. > > But just the four commits need to notify so many people. > And four commits are independent. So I split that patch set, > let us review these first. > > The patch set try to refactor the params of find_vqs(). > Then we can just change the structure, when introducing new > features. > > Thanks. > > v3: > 1. fix the bug: "assignment of read-only location '*cfg.names'" > > v2: > 1. add kerneldoc for "struct vq_transport_config" @ilpo.jarvinen > > v1: > 1. fix some comments from ilpo.jarvinen@linux.intel.com > As this came in after merge window was open I'm deferring this to the next merge window. Jason, can you pls try to complete the review meanwhile? > > Xuan Zhuo (4): > virtio: find_vqs: pass struct instead of multi parameters > virtio: vring_create_virtqueue: pass struct instead of multi > parameters > virtio: vring_new_virtqueue(): pass struct instead of multi parameters > virtio_ring: simplify the parameters of the funcs related to > vring_create/new_virtqueue() > > arch/um/drivers/virtio_uml.c | 31 ++-- > drivers/platform/mellanox/mlxbf-tmfifo.c | 24 ++-- > drivers/remoteproc/remoteproc_virtio.c | 31 ++-- > drivers/s390/virtio/virtio_ccw.c | 33 ++--- > drivers/virtio/virtio_mmio.c | 30 ++-- > drivers/virtio/virtio_pci_common.c | 60 ++++---- > drivers/virtio/virtio_pci_common.h | 9 +- > drivers/virtio/virtio_pci_legacy.c | 16 ++- > drivers/virtio/virtio_pci_modern.c | 38 +++-- > drivers/virtio/virtio_ring.c | 173 ++++++++--------------- > drivers/virtio/virtio_vdpa.c | 45 +++--- > include/linux/virtio_config.h | 85 ++++++++--- > include/linux/virtio_ring.h | 93 +++++++----- > tools/virtio/virtio_test.c | 4 +- > tools/virtio/vringh_test.c | 28 ++-- > 15 files changed, 363 insertions(+), 337 deletions(-) > > -- > 2.32.0.3.g01195cf9f