From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 356DBC25B77 for ; Wed, 22 May 2024 12:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUgbrkFHxg4F+kRJ096ILydWxQUTBg55cdfx2xz7DQs=; b=w1fzEpSTR/XzleVNFJQ8DKJTZD fALKTOMQLADDpuoWXdvGQ4dUkzTOZ/LJYz9csDJOL09JZ6kB5SNh3OrcwgRG42IUg+WpfnQ+YOw3d 4P3ZZNRCJDuhKnHd+0IcRTuX785hwcPQ1sxxMdoeDR/rUfdVgdIS1WBh7MBPQpy02+/7t2tgslP1F DdQT1ppIp4FuS1yfJ5K8Xd6ihIBoK9+90R+lxMYGf4mLf1238v3t4FWz2WZGh82y/g6OjwpzbQgtn qmk/TrZtgylxUg4zo3qnN5wU6TWSR4+bpPyKnhAxR0IN9LaXZFXn2hgb1LP2+KziUcxrNQQJEztm7 HjWEbXgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9lK7-00000002xdE-2Xke; Wed, 22 May 2024 12:44:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9lK4-00000002xc7-31Fg for linux-um@lists.infradead.org; Wed, 22 May 2024 12:44:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716381837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KUgbrkFHxg4F+kRJ096ILydWxQUTBg55cdfx2xz7DQs=; b=BTChjxTiBvJS7zguW8hn7Y+U5uDwKjdTKWfStIdB2gP1v4rUCPA2+aKDAbxxEwgBdff1Oe 8jBfEVfDKeQUshje7utj/JK7S2Qa50RbCT8mPK+0bDVE/+DOpYMxpmzylbBi4NfPIg28xL y7Z+ws3O8GvL7CRC4ssxQQh2HKEdD6A= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-OwjQqT_iPvGaCyXzODOrvg-1; Wed, 22 May 2024 08:43:54 -0400 X-MC-Unique: OwjQqT_iPvGaCyXzODOrvg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-34dce5456c3so10644605f8f.0 for ; Wed, 22 May 2024 05:43:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716381833; x=1716986633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KUgbrkFHxg4F+kRJ096ILydWxQUTBg55cdfx2xz7DQs=; b=wnzVo+CZQ/tx3lvHJ54PlnqyFkHkJlP0+tkgUuya0OAHNOVYBKwklG0LYf872ewNXq 7CHXRhjNzqsptcjGG6Aen3MSCysUCg+NF0exsfu+Vs+Hl/tAJ5C6ubyfwnxMviluhcbZ qHhpF16Weie1EGB6BS0dV7y/pllk9v/DpEhZjfvbCiegSE8zdDHYGZnPKB1Pptt+y8K8 UF2z6+wWAArLWxUAZe5fp653fevrtTEwpwboIvsfoSZFOkqk5baBWU4uG6vuo3O1kSTx E+ydAQfOTj6rxLU2lp6JkYTZMiuEc7dQkvgCEwHBv66q7gOSCjo62iP+7KNBrPxA2YO7 UiYQ== X-Forwarded-Encrypted: i=1; AJvYcCVgprmVHOEJ9Dj/CDMC/CpHo+hd0GB4EFfP/3i+ptGOAfRnf/eS3MYlh4T9Vtq+MOze28XVsPNNLUeebT+tU7GesX+B+usr39VhcqIM X-Gm-Message-State: AOJu0YzPvQn+xMfO9UA15jxXNsKpPhQNrqQ0ovbS0hS6ziAuJtVQzNCW 0GTl4E6xKFmwJcWD8WF2ueIbXr/BR5139SDH6vO3By3BkNsXj7GPyWVAlfFivs+gGRdJ79MbQAP VWjZ7nULZMvsYbv18xfjdtkL1mTthZi50XZ3chDabH4QTCqERq//rF0kWD4pkig== X-Received: by 2002:a05:6000:d1:b0:354:c2c3:a319 with SMTP id ffacd0b85a97d-354d8dad7camr1537132f8f.61.1716381832852; Wed, 22 May 2024 05:43:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxFpLqeLCJUrO7rqx1MM8b891NleWkGLj5GGveBxw1L4XYP6vJDRZB7/pPW2A9B5hgEhmBdw== X-Received: by 2002:a05:6000:d1:b0:354:c2c3:a319 with SMTP id ffacd0b85a97d-354d8dad7camr1537078f8f.61.1716381832095; Wed, 22 May 2024 05:43:52 -0700 (PDT) Received: from redhat.com ([2a0d:6fc7:55d:e862:558a:a573:a176:1825]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-354c7df311esm7583246f8f.3.2024.05.22.05.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 05:43:51 -0700 (PDT) Date: Wed, 22 May 2024 08:43:44 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: virtualization@lists.linux.dev, Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , David Hildenbrand , Jason Wang , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH vhost v9 0/6] refactor the params of find_vqs() Message-ID: <20240522084221-mutt-send-email-mst@kernel.org> References: <20240424091533.86949-1-xuanzhuo@linux.alibaba.com> <20240522082732-mutt-send-email-mst@kernel.org> <1716381321.6426032-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <1716381321.6426032-1-xuanzhuo@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_054400_868238_68435A77 X-CRM114-Status: GOOD ( 34.27 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Wed, May 22, 2024 at 08:35:21PM +0800, Xuan Zhuo wrote: > On Wed, 22 May 2024 08:28:43 -0400, "Michael S. Tsirkin" wrote: > > On Wed, Apr 24, 2024 at 05:15:27PM +0800, Xuan Zhuo wrote: > > > This pathset is splited from the > > > > > > http://lore.kernel.org/all/20240229072044.77388-1-xuanzhuo@linux.alibaba.com > > > > > > That may needs some cycles to discuss. But that notifies too many people. > > > > > > But just the four commits need to notify so many people. > > > And four commits are independent. So I split that patch set, > > > let us review these first. > > > > > > The patch set try to refactor the params of find_vqs(). > > > Then we can just change the structure, when introducing new > > > features. > > > > > > Thanks. > > > > It's nice but I'd like to see something that uses this before I bother > > merging. IIUC premapped is dropped - are we going to use this in practice? > > > 1. You know this modification makes sense. > 2. This modification is difficult. Unlike modifying virtio ring or virtio-net, > this patch set requires modifying many modules and being reviewed by > many people. > 3. If you do not merge it now, then this patch set will most likely be > abandoned. And I worked a lot on that. > 4. premapped has not been abandoned, I have been advancing this work. What was > abandoned was just virtio-net big mode's support for premapped. > 5. My plan is to complete virtio-net support for af-xdp in 6.10. This must > depend on premapped. > > So, I hope you merge this patch set. > > Thanks. If this makes thing easier for you, I can put it in my tree post release. This way you do not need to keep reposting it. I'll then merge it with premapped. > > > > > > v8: > > > 1. rebase the vhost branch > > > > > > v7: > > > 1. fix two bugs. @Jason > > > > > > v6: > > > 1. virtio_balloon: a single variable for both purposes. > > > 2. if names[i] is null, return error > > > > > > v5: > > > 1. virtio_balloon: follow David Hildenbrand's suggest > > > http://lore.kernel.org/all/3620be9c-e288-4ff2-a7be-1fcf806e6e6e@redhat.com > > > 2. fix bug of the reference of "cfg_idx" > > > http://lore.kernel.org/all/202403222227.Sdp23Lcb-lkp@intel.com > > > > > > v4: > > > 1. remove support for names array entries being null > > > 2. remove cfg_idx from virtio_vq_config > > > > > > v3: > > > 1. fix the bug: "assignment of read-only location '*cfg.names'" > > > > > > v2: > > > 1. add kerneldoc for "struct vq_transport_config" @ilpo.jarvinen > > > > > > v1: > > > 1. fix some comments from ilpo.jarvinen@linux.intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Xuan Zhuo (6): > > > virtio_balloon: remove the dependence where names[] is null > > > virtio: remove support for names array entries being null. > > > virtio: find_vqs: pass struct instead of multi parameters > > > virtio: vring_create_virtqueue: pass struct instead of multi > > > parameters > > > virtio: vring_new_virtqueue(): pass struct instead of multi parameters > > > virtio_ring: simplify the parameters of the funcs related to > > > vring_create/new_virtqueue() > > > > > > arch/um/drivers/virtio_uml.c | 36 +++-- > > > drivers/platform/mellanox/mlxbf-tmfifo.c | 23 +-- > > > drivers/remoteproc/remoteproc_virtio.c | 37 +++-- > > > drivers/s390/virtio/virtio_ccw.c | 38 ++--- > > > drivers/virtio/virtio_balloon.c | 48 +++--- > > > drivers/virtio/virtio_mmio.c | 36 +++-- > > > drivers/virtio/virtio_pci_common.c | 69 ++++----- > > > drivers/virtio/virtio_pci_common.h | 9 +- > > > drivers/virtio/virtio_pci_legacy.c | 16 +- > > > drivers/virtio/virtio_pci_modern.c | 37 +++-- > > > drivers/virtio/virtio_ring.c | 177 ++++++++--------------- > > > drivers/virtio/virtio_vdpa.c | 51 +++---- > > > include/linux/virtio_config.h | 76 +++++++--- > > > include/linux/virtio_ring.h | 93 +++++++----- > > > tools/virtio/virtio_test.c | 4 +- > > > tools/virtio/vringh_test.c | 28 ++-- > > > 16 files changed, 384 insertions(+), 394 deletions(-) > > > > > > -- > > > 2.32.0.3.g01195cf9f > >