From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4125EC27C53 for ; Wed, 19 Jun 2024 14:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eJOrfEPrFo8uEVb7cr0iHnKgLybdEjwizcufdY6KNC4=; b=ch9ReoqGmvCBaV5XiclufcGCJb Anl+6OBdtuxPRGvAQVLGhoczUtOhv0GAHZICLGZBkPHNJIkuLYAvyLKPAI8SV/279fNTcOsOC4nC0 fSV3Yp4VdcDFdBj+3UvTn6oiEYtFjp47I3gIl7r2d4dRC05tOmKTdDX4BDQNv86uPhdSwabF94iNj iXTQqP0ng65XbeXzyny3WaU81R1vCUlquXuTO+V7VIKyFyIyQIzbSQQbfAYjAm1Vs7eGb2IjsFg3f Zj4t4sGH53nU46JEcNpmagStFOD5LLqvmo9EFn9A4U80YgzK5PPVS9/zdykR27d1j9pQOaIoJDsxF G0em7UeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJwEB-00000001VPQ-3kKk; Wed, 19 Jun 2024 14:23:59 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJwE3-00000001VMH-3TgA; Wed, 19 Jun 2024 14:23:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id D67B368AFE; Wed, 19 Jun 2024 16:23:40 +0200 (CEST) Date: Wed, 19 Jun 2024 16:23:40 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: move features flags into queue_limits v2 Message-ID: <20240619142340.GA32100@lst.de> References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_072355_725200_F8CD9F03 X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Wed, Jun 19, 2024 at 08:21:14AM -0600, Jens Axboe wrote: > Please check for-6.11/block, as I pulled in the changes to the main > block branch and that threw some merge conflicts mostly due to Damien's > changes in for-6.11/block. While fixing those up, I also came across > oddities like: > > (limits->features & limits->features & BLK_FEAT_ZONED)) { > > which don't make much sense and hence I changed them to > > (limits->features & BLK_FEAT_ZONED)) { Yeah. The above is harmless but of course completely pointless.