From: Nathan Chancellor <nathan@kernel.org>
To: Wentao Zhang <wentaoz5@illinois.edu>
Cc: Matt.Kelly2@boeing.com, akpm@linux-foundation.org,
andrew.j.oppelt@boeing.com, anton.ivanov@cambridgegreys.com,
ardb@kernel.org, arnd@arndb.de, bhelgaas@google.com,
bp@alien8.de, chuck.wolber@boeing.com,
dave.hansen@linux.intel.com, dvyukov@google.com, hpa@zytor.com,
jinghao7@illinois.edu, johannes@sipsolutions.net,
jpoimboe@kernel.org, justinstitt@google.com, kees@kernel.org,
kent.overstreet@linux.dev, linux-arch@vger.kernel.org,
linux-efi@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-um@lists.infradead.org, llvm@lists.linux.dev,
luto@kernel.org, marinov@illinois.edu, masahiroy@kernel.org,
maskray@google.com, mathieu.desnoyers@efficios.com,
matthew.l.weber3@boeing.com, mhiramat@kernel.org,
mingo@redhat.com, morbo@google.com, ndesaulniers@google.com,
oberpar@linux.ibm.com, paulmck@kernel.org, peterz@infradead.org,
richard@nod.at, rostedt@goodmis.org, samitolvanen@google.com,
samuel.sarkisian@boeing.com, steven.h.vanderleest@boeing.com,
tglx@linutronix.de, tingxur@illinois.edu, tyxu@illinois.edu,
x86@kernel.org
Subject: Re: [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang
Date: Tue, 1 Oct 2024 21:53:47 -0700 [thread overview]
Message-ID: <20241002045347.GE555609@thelio-3990X> (raw)
In-Reply-To: <20240905043245.1389509-1-wentaoz5@illinois.edu>
Hi Wentao,
I took this series for a spin on next-20241001 with LLVM 19.1.0 using a
distribution configuration tailored for a local development VM using
QEMU. You'll notice on the rebase for 6.12-rc1 but there is a small
conflict in kernel/Makefile due to commit 0e8b67982b48 ("mm: move
kernel/numa.c to mm/").
I initially did the build on one of my test machines which has 16
threads with 32GB of RAM and ld.lld got killed while linking vmlinux.o.
Is your comment in the MC/DC patch "more memory is consumed if larger
decisions are getting counted" relevant here or is that talking about
runtime memory on the target device? I assume the latter but I figured I
would make sure. If not, it might be worth a comment somewhere that this
can also require some heftier build resources possibly? If that is not
expected, I am happy to help look into why it is happening.
I was able to successfully build that same configuration and setup with
my primary workstation, which is much beefier. Unfortunately, the
resulting kernel did not boot with my usual VM testing setup. I will see
if I can narrow down a particular configuration option that causes this
tomorrow because I did a test with defconfig +
CONFIG_LLVM_COV_PROFILE_ALL and it booted fine. Perhaps some other
option that is not compatible with this? I'll follow up with more
information as I have it.
On the integration front, I think the -mm tree, run by Andrew Morton,
would probably be the best place to land this with Acks from the -tip
folks for the x86 bits? Once the issue above has been understood, I
think you can send v3 with any of the comments I made addressed and a
potential fix for the above issue if necessary directly to him, instead
of just on cc, so that it gets his attention. Other maintainers are free
to argue that it should go through their trees instead but I think it
would be good to decide on that sooner rather than later so this
patchset is not stuck in limbo.
Cheers,
Nathan
next prev parent reply other threads:[~2024-10-02 4:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 23:06 [RFC PATCH 0/3] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Wentao Zhang
2024-08-24 23:06 ` [RFC PATCH 1/3] llvm-cov: add Clang's Source-based Code Coverage support Wentao Zhang
2024-08-25 11:52 ` Thomas Gleixner
2024-08-24 23:06 ` [RFC PATCH 2/3] kbuild, llvm-cov: disable instrumentation in odd or sensitive code Wentao Zhang
2024-08-25 12:12 ` Thomas Gleixner
2024-08-24 23:06 ` [RFC PATCH 3/3] llvm-cov: add Clang's MC/DC support Wentao Zhang
2024-09-05 4:32 ` [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Wentao Zhang
2024-09-05 4:32 ` [PATCH v2 1/4] llvm-cov: add Clang's Source-based Code Coverage support Wentao Zhang
2024-10-02 0:30 ` Nathan Chancellor
2024-09-05 4:32 ` [PATCH v2 2/4] llvm-cov: add Clang's MC/DC support Wentao Zhang
2024-10-02 1:10 ` Nathan Chancellor
2024-10-03 3:14 ` Wentao Zhang
2024-09-05 4:32 ` [PATCH v2 3/4] x86: disable llvm-cov instrumentation Wentao Zhang
2024-10-02 1:17 ` Nathan Chancellor
2024-09-05 4:32 ` [PATCH v2 4/4] x86: enable llvm-cov support Wentao Zhang
2024-10-02 1:18 ` Nathan Chancellor
2024-09-05 11:41 ` [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Peter Zijlstra
[not found] ` <BN0P110MB1785427A8771BD53DADB2E4DAB9DA@BN0P110MB1785.NAMP110.PROD.OUTLOOK.COM>
[not found] ` <BN0P110MB1785CA856C1898EEC22ACD7EAB9DA@BN0P110MB1785.NAMP110.PROD.OUTLOOK.COM>
2024-09-05 12:24 ` FW: [EXTERNAL] " Steve VanderLeest
2024-09-05 18:07 ` Wentao Zhang
2024-10-02 4:53 ` Nathan Chancellor [this message]
2024-10-02 6:42 ` Wentao Zhang
2024-10-03 23:29 ` Nathan Chancellor
2024-10-09 3:17 ` Wentao Zhang
2024-11-22 5:05 ` Jinghao Jia
2024-11-23 4:39 ` Nathan Chancellor
2025-08-29 18:10 ` Nathan Chancellor
2025-10-14 23:26 ` [RFC PATCH 0/4] Enable Clang's Source-based Code Coverage and MC/DC for x86-64 Sasha Levin
2025-10-14 23:26 ` [RFC PATCH 1/4] llvm-cov: add Clang's Source-based Code Coverage support Sasha Levin
2025-10-14 23:26 ` [RFC PATCH 2/4] llvm-cov: add Clang's MC/DC support Sasha Levin
2025-10-14 23:26 ` [RFC PATCH 3/4] x86: disable llvm-cov instrumentation Sasha Levin
2025-10-14 23:26 ` [RFC PATCH 4/4] x86: enable llvm-cov support Sasha Levin
2025-10-15 7:37 ` [RFC PATCH 0/4] Enable Clang's Source-based Code Coverage and MC/DC for x86-64 Peter Zijlstra
2025-10-15 8:26 ` Chuck Wolber
2025-10-15 9:21 ` Peter Zijlstra
2024-11-22 12:27 ` [PATCH v2 0/4] Enable measuring the kernel's Source-based Code Coverage and MC/DC with Clang Peter Zijlstra
2024-11-22 19:28 ` [EXTERNAL] " Wolber (US), Chuck
2024-11-23 3:09 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002045347.GE555609@thelio-3990X \
--to=nathan@kernel.org \
--cc=Matt.Kelly2@boeing.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.j.oppelt@boeing.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=chuck.wolber@boeing.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=jinghao7@illinois.edu \
--cc=johannes@sipsolutions.net \
--cc=jpoimboe@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-arch@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=marinov@illinois.edu \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=matthew.l.weber3@boeing.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=oberpar@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=samuel.sarkisian@boeing.com \
--cc=steven.h.vanderleest@boeing.com \
--cc=tglx@linutronix.de \
--cc=tingxur@illinois.edu \
--cc=tyxu@illinois.edu \
--cc=wentaoz5@illinois.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).