* [PATCH] sonypi: add depends on HAS_IOPORT
@ 2025-06-15 18:36 Randy Dunlap
2025-06-17 6:37 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2025-06-15 18:36 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Arnd Bergmann, Niklas Schnelle, Mattia Dongili,
platform-driver-x86, linux-um, Hans de Goede, Ilpo Järvinen,
Greg Kroah-Hartman
The sonypi driver uses inb()/outb() without depending on HAS_IOPORT,
which leads to build errors since kernel v6.13-rc1:
commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
for HAS_IOPORT=n")
Add the HAS_IOPORT dependency to prevent the build errors.
(Found in ARCH=um allmodconfig builds)
In function ‘inb_p’,
inlined from ‘sonypi_call2’ at ../drivers/char/sonypi.c:651:2:
include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
542 | #define _inb _inb
drivers/char/sonypi.c: In function ‘sonypi_call2’:
include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
596 | #define _outb _outb
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@kernel.org>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Mattia Dongili <malattia@linux.it>
Cc: platform-driver-x86@vger.kernel.org
Cc: linux-um@lists.infradead.org
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/char/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-616-rc1.orig/drivers/char/Kconfig
+++ lnx-616-rc1/drivers/char/Kconfig
@@ -237,7 +237,7 @@ config APPLICOM
config SONYPI
tristate "Sony Vaio Programmable I/O Control Device support"
- depends on X86_32 && PCI && INPUT
+ depends on X86_32 && PCI && INPUT && HAS_IOPORT
depends on ACPI_EC || !ACPI
help
This driver enables access to the Sony Programmable I/O Control
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 # v6.16-rc1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sonypi: add depends on HAS_IOPORT
2025-06-15 18:36 [PATCH] sonypi: add depends on HAS_IOPORT Randy Dunlap
@ 2025-06-17 6:37 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2025-06-17 6:37 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Arnd Bergmann, Niklas Schnelle, Mattia Dongili,
platform-driver-x86, linux-um, Hans de Goede, Ilpo Järvinen,
Greg Kroah-Hartman
> config SONYPI
> tristate "Sony Vaio Programmable I/O Control Device support"
> - depends on X86_32 && PCI && INPUT
> + depends on X86_32 && PCI && INPUT && HAS_IOPORT
I sent the same fix b efore, but not sure it ended up going anywhere,
although Greg said he'd pick it up, I think:
https://lore.kernel.org/lkml/20250606071255.7722-2-johannes@sipsolutions.net/
Anyway don't really care which one gets applied, they're the same anyway
:-)
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-15 18:36 [PATCH] sonypi: add depends on HAS_IOPORT Randy Dunlap
2025-06-17 6:37 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).