linux-um.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Berg <benjamin@sipsolutions.net>
To: linux-um@lists.infradead.org, "Willy Tarreau" <w@1wt.eu>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	linux-kselftest@vger.kernel.org,
	"Arnaldo Carvalho de Melo" <acme@redhat.com>
Cc: linux-kernel@vger.kernel.org, Benjamin Berg <benjamin.berg@intel.com>
Subject: [PATCH v3 03/12] tools/nolibc/stdio: let perror work when NOLIBC_IGNORE_ERRNO is set
Date: Wed, 24 Sep 2025 16:20:50 +0200	[thread overview]
Message-ID: <20250924142059.527768-4-benjamin@sipsolutions.net> (raw)
In-Reply-To: <20250924142059.527768-1-benjamin@sipsolutions.net>

From: Benjamin Berg <benjamin.berg@intel.com>

There is no errno variable when NOLIBC_IGNORE_ERRNO is defined. As such,
simply print the message with "unknown error" rather than the integer
value of errno.

Fixes: acab7bcdb1bc ("tools/nolibc/stdio: add perror() to report the errno value")
Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>

---
v3:
- Change the message instead of removing perror entirely
---
 tools/include/nolibc/stdio.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
index 7630234408c5..724d05ce6962 100644
--- a/tools/include/nolibc/stdio.h
+++ b/tools/include/nolibc/stdio.h
@@ -600,7 +600,11 @@ int sscanf(const char *str, const char *format, ...)
 static __attribute__((unused))
 void perror(const char *msg)
 {
+#ifdef NOLIBC_IGNORE_ERRNO
+	fprintf(stderr, "%s%sunknown error\n", (msg && *msg) ? msg : "", (msg && *msg) ? ": " : "");
+#else
 	fprintf(stderr, "%s%serrno=%d\n", (msg && *msg) ? msg : "", (msg && *msg) ? ": " : "", errno);
+#endif
 }
 
 static __attribute__((unused))
-- 
2.51.0



  parent reply	other threads:[~2025-09-24 14:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 14:20 [PATCH v3 00/12] Start porting UML to nolibc Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 01/12] tools compiler.h: fix __used definition Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 02/12] um: use tools/include for user files Benjamin Berg
2025-09-24 14:20 ` Benjamin Berg [this message]
2025-09-25 16:22   ` [PATCH v3 03/12] tools/nolibc/stdio: let perror work when NOLIBC_IGNORE_ERRNO is set Thomas Weißschuh
2025-09-24 14:20 ` [PATCH v3 04/12] tools/nolibc/dirent: avoid errno in readdir_r Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 05/12] tools/nolibc: implement %m if errno is not defined Benjamin Berg
2025-09-25 16:24   ` Thomas Weißschuh
2025-09-24 14:20 ` [PATCH v3 06/12] tools/nolibc: use __fallthrough__ rather than fallthrough Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 07/12] tools/nolibc: add option to disable runtime Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 08/12] um: add infrastructure to build files using nolibc Benjamin Berg
2025-09-25 16:36   ` Thomas Weißschuh
2025-09-24 14:20 ` [PATCH v3 09/12] um: use nolibc for the --showconfig implementation Benjamin Berg
2025-09-26 12:57   ` kernel test robot
2025-10-20 14:21     ` Thomas Weißschuh
2025-10-29 14:07       ` Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 10/12] tools/nolibc: add uio.h with readv and writev Benjamin Berg
2025-09-24 14:20 ` [PATCH v3 11/12] tools/nolibc: add ptrace support Benjamin Berg
2025-09-25 16:28   ` Thomas Weißschuh
2025-09-24 14:20 ` [PATCH v3 12/12] um: switch ptrace FP register access to nolibc Benjamin Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250924142059.527768-4-benjamin@sipsolutions.net \
    --to=benjamin@sipsolutions.net \
    --cc=acme@redhat.com \
    --cc=benjamin.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linux@weissschuh.net \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).