From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D6DEDA693 for ; Tue, 3 Mar 2026 16:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rJRp/y7VgPI6vyHfr+t6GYOFYk0QK/kcXciT+38Vnow=; b=gT1t2IsGy93zbpmlC6hl33gjhz EE2c7xwfJ06Goklio2/zjQL5NjglxvfKMLUlKQbvrpkIyy7RQa7YA1sSSaWx+2WItLb18HnRaoa0s 9GC6gYR8HYR3VOzPasyxv/xUgii1rhBhJR77uRpSbPqneeiSDdCEL1HKGZAC8+G82KBDJV0ZAdp5u 4JkPcu2JYZYq34B4WKykm5YjtExHH32bdEYD8ESmB7wYa05cU1/UuwBNSKEHpTW7uSX+zuaJ+cfmo KMowZa0Zm0LmilBPCdoE78CBwTof4HZKNDegnQxu6KpWyWFdQA5iN8g8FwywsDM1DSoaFOd9s3+rW nyg/yRqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxSOt-0000000FXbL-2Af5; Tue, 03 Mar 2026 16:15:11 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxSOr-0000000FXae-0w6I; Tue, 03 Mar 2026 16:15:10 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 59EE368BEB; Tue, 3 Mar 2026 17:15:00 +0100 (CET) Date: Tue, 3 Mar 2026 17:15:00 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 07/25] xor: split xor.h Message-ID: <20260303161500.GA8975@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-8-hch@lst.de> <20260228044355.GD65277@quark> <20260303160309.GD7021@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303160309.GD7021@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260303_081509_419662_40F39EA2 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Tue, Mar 03, 2026 at 05:03:09PM +0100, Christoph Hellwig wrote: > On Fri, Feb 27, 2026 at 08:43:55PM -0800, Eric Biggers wrote: > > On Thu, Feb 26, 2026 at 07:10:19AM -0800, Christoph Hellwig wrote: > > > Keep xor.h for the public API, and split the struct xor_block_template > > > definition that is only needed by the xor.ko core and > > > architecture-specific optimizations into a separate xor_impl.h header. > > > > > > Signed-off-by: Christoph Hellwig > > > --- > > > arch/arm/lib/xor-neon.c | 1 + > > > arch/s390/lib/xor.c | 2 +- > > > include/linux/raid/xor.h | 22 +--------------------- > > > include/linux/raid/xor_impl.h | 25 +++++++++++++++++++++++++ > > > lib/raid/xor/xor-core.c | 1 + > > > 5 files changed, 29 insertions(+), 22 deletions(-) > > > create mode 100644 include/linux/raid/xor_impl.h > > > > arch/arm64/lib/xor-neon.c needs to be updated to include xor_impl.h. > > As of this patch it is not using anything from that header (but > neither from the public xor.h). Actually looks like we do need it because it pulls in arch/arm64/include/asm/xor.h. Anyway, I think I'll actually move this patch to the end so that the impl header does not need moving to it's final place.