From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01C4CFCC9D1 for ; Tue, 10 Mar 2026 06:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Ah7Wu2DCLVKZbjG52xH4VxSemU6UyDO7HEM5lRKrUc=; b=P3eDOHFrLLTq7VIadU/PQMNrTZ 0U+z4oTvDbLkqVE4QscKsS5E9Zw/wMKOYRxhaI+mklDazXQT85ov0e0gLbLrFYIJ9FH7Lq1gc0BK8 BS/RQCCLpcM8wHuPkQPCzHUZJ1K3mus2Dty/mqLkhnUxRvhtHkWJPnxqKjyEOBwl8cS/wKZmqfPtT g/QsjUQY8qgdX9bOfHog62p5t2ddx6fb7EiUGSUt+gHCFPyJpj8VWqZD77D5xe0en+5DNQhGnoN7G SU8RPh6scDeTTGInGppzSMJs+l2/aZrJPys80Jq9+TRNjQs3/xWiosrMpgIzsQbAWudUu6pqX1S53 vaZNy3Kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzr3Q-00000008pG1-28qq; Tue, 10 Mar 2026 06:58:56 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzr3N-00000008pFP-1IPT; Tue, 10 Mar 2026 06:58:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7056668AFE; Tue, 10 Mar 2026 07:58:40 +0100 (CET) Date: Tue, 10 Mar 2026 07:58:40 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 21/25] xor: add a better public API Message-ID: <20260310065840.GA10296@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-22-hch@lst.de> <20260228065038.GH65277@quark> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260228065038.GH65277@quark> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260309_235853_494793_57C1EB56 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Fri, Feb 27, 2026 at 10:50:38PM -0800, Eric Biggers wrote: > > +void xor_gen(void *dest, void **srcss, unsigned int src_cnt, > > + unsigned int bytes); > > srcss => srcs > > Ideally the source vectors would be 'const' as well. I looked at the constification, and it's a bit painful because the same source arrays are also passed to the raid6 code by the callers. I'll clean up the raid6 API first, and then will give it another spin.