From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD2F210F2862 for ; Fri, 27 Mar 2026 17:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Mime-Version:References:In-Reply-To:Message-Id:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NEcgHCbJlBBYTZQ+XgLbmm3KVd9zLogDyBiIDz8me5A=; b=kDfBkzlJVmFCogZWYolNpJ2/IA 8VMo7iTqPoRM3W4IQTc+f0vSlLWkOqPQIkkfQOeEclzMXEx7hNi2ka+bmzNfbPOwjyv+wszU2xv6S ReOzuD7TEI3sgbZsVV+c446pXthhjn7WqjTQpzKStYX8EuOS+6RTqqL8vfweHh9RqQslVbMO/WD1v lpkyM7lW/hsJeNHwqhi61Wh3jJWagBzWWlSPPdPR0JcywLvDwm1iQ1mYN0PzwcHA2e+H9l5vsK+r2 7wQ92H09OxCEU6ztrW0wkSMQvtUzfbN9pUlSTLrQSvUcFU+Cf3tqgLW2fCkSmQ00fDPhcGt5KRTQv 2uS2RLMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w6BLJ-00000007t3A-1sbF; Fri, 27 Mar 2026 17:51:33 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w6BLG-00000007t2F-1E5a; Fri, 27 Mar 2026 17:51:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8BA7343C23; Fri, 27 Mar 2026 17:51:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF370C19423; Fri, 27 Mar 2026 17:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774633889; bh=ut3C5Oibhu02lZBarl5gtLhPMmjWlwAPsAficDpw9oU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tDB0MgLHz5uhVLWEaFReNs99y5u/YY74Iml33dpseoOBD0A8VJRFFQYeU9FvqxCuP nyqAUmYCNk1T74zARlT1dAb3bA7OmvIjh9mNwh7l1JQENaDWThwxkEsSuzSKK+Qc4+ obJODpvlMAd7z/q0AZNLNKGt9R6dV77UeQmuFqzk= Date: Fri, 27 Mar 2026 10:51:27 -0700 From: Andrew Morton To: Christoph Hellwig Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , "Theodore Ts'o" , "Jason A. Donenfeld" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 23/28] xor: add a better public API Message-Id: <20260327105127.1a1f3895adb14681141a0a30@linux-foundation.org> In-Reply-To: <20260327061704.3707577-24-hch@lst.de> References: <20260327061704.3707577-1-hch@lst.de> <20260327061704.3707577-24-hch@lst.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260327_105130_357183_E7BEA20F X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Fri, 27 Mar 2026 07:16:55 +0100 Christoph Hellwig wrote: > xor_blocks is very annoying to use, because it is limited to 4 + 1 > sources / destinations, has an odd argument order and is completely > undocumented. > > Lift the code that loops around it from btrfs and async_tx/async_xor into > common code under the name xor_gen and properly document it. Something funny here - two different patches with the same title and changelog. If you can send over new versions of title&changelog I can paste that in.