From: FUJITA Tomonori <tomo@flapping.org>
To: miguel.ojeda.sandonis@gmail.com
Cc: tomo@flapping.org, ojeda@kernel.org, richard@nod.at,
anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net,
a.hindborg@kernel.org, acourbot@nvidia.com, aliceryhl@google.com,
bjorn3_gh@protonmail.com, boqun@kernel.org, dakr@kernel.org,
daniel.almeida@collabora.com, gary@garyguo.net,
lossin@kernel.org, tamird@kernel.org, tmgross@umich.edu,
work@onurozkan.dev, rust-for-linux@vger.kernel.org,
linux-um@lists.infradead.org, fujita.tomonori@gmail.com,
david@davidgow.net
Subject: Re: [PATCH v1] rust: bug: fix warn_on macro build error on UML
Date: Fri, 07 Aug 2026 20:19:19 +0900 (JST) [thread overview]
Message-ID: <20260807.201919.866808779586212952.tomo@flapping.org> (raw)
In-Reply-To: <CANiq72kzmPnu_UPHryLMSwGMmTruirNUL5H+aD4tMiNUqqRELw@mail.gmail.com>
On Fri, 7 Aug 2026 08:52:38 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Sat, Aug 1, 2026 at 5:41 AM FUJITA Tomonori <tomo@flapping.org> wrote:
>>
>> Use the free function `as_char_ptr_in_const_context()` instead, as other exported macros already do.
>
> I reproduced this and the fix works -- thanks Tomonori!
>
> Do we need to use the free function? i.e. this is not a const context,
> so should we do e.g.
>
> $crate::str::CStrExt::as_char_ptr
>
> ?
Thanks, you are right. I'll send v2 shortly.
> Also:
>
> Cc: stable@vger.kernel.org
Ok.
prev parent reply other threads:[~2026-08-07 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 2:25 [PATCH v1] rust: bug: fix warn_on macro build error on UML FUJITA Tomonori
2026-08-07 6:52 ` Miguel Ojeda
2026-08-07 6:54 ` Miguel Ojeda
2026-08-07 11:19 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807.201919.866808779586212952.tomo@flapping.org \
--to=tomo@flapping.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=david@davidgow.net \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=johannes@sipsolutions.net \
--cc=linux-um@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=richard@nod.at \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox